Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons: Permanently enabling physics on in-room objects doesn't work correctly #6521

Open
Exairnous opened this issue Nov 20, 2024 · 0 comments
Labels
bug needs triage For bugs that have not yet been assigned a fix priority

Comments

@Exairnous
Copy link
Contributor

Description
Applies to: #6468
This affects both the bitECS and A-Frame loaders.

For the bitECS loader:
Physics doesn't continue working after moving an object that has had physics permanently enabled on it. Physics initially works immediately after enabling it on an in-room object, but stops working after the object is moved by the user.

For the A-Frame loader:
Physics will work initially when permanently enabled, but you can't move the object afterward because of bug #6518. If you work around bug #6518, then permanently enabling physics either doesn't work at all or acts the same as for the bitECS loader.

To Reproduce
Steps to reproduce the behavior:

For the bitECS loader:

  1. Enter a Hubs room with the bitECS loader enabled (this can be set in the room settings).
  2. Drag and drop a GLB file that you have locally on your computer into the room (or use Place -> Upload). This file can be downloaded and used to test if you don't have any GLBs handy: Test_Cube.zip.
  3. Hover over the object with your mouse and press and hold spacebar to bring up its menu (you may have to move your avatar around a bit to get it to show up).
  4. Click on the ball with a downwards arrow to permanently enable physics.
    2024-09-27_03-32
  5. See the object drop to the ground.
  6. Click and drag the object to a new position in space.
  7. See that the object doesn't drop to the ground when you release the mouse button.

For the A-Frame loader:

  1. Enter a Hubs room with the A-Frame loader enabled (this is the default for new rooms, but the A-Frame and bitECS loaders can be toggled between in the room settings at any time).
  2. Drag and drop a GLB file that you have locally on your computer into the room (or use Place -> Upload). This file can be downloaded and used to test if you don't have any GLBs handy: Test_Cube.zip.
  3. Hover over the object with your mouse and press and hold spacebar to bring up its menu (you may have to move your avatar around a bit to get it to show up).
  4. Click on the ball with a downwards arrow to permanently enable physics.
    2024-09-27_03-32
  5. See the object drop to the ground.
  6. See that you can't move it because of bug #6518.
  7. Drag and drop the GLB file that you have locally on your computer into the room again so you have another copy (or use Place -> Upload).
  8. Spawn a media frame cube via the /cube chat command.
  9. Use the media frame cube to capture the object to allow moving the object.
  10. Move the object outside of the media frame (steps 8-10 work around bug #6518).
  11. Hover over the object with your mouse and press and hold spacebar to bring up its menu (you may have to move your avatar around a bit to get it to show up).
  12. Click on the ball with a downwards arrow to permanently enable physics.
    2024-09-27_03-32
  13. See that either nothing happens at all, or the object will drop to the ground once, but then never again after you move it (the same behavior as is displayed with bitECS).

Expected behavior
The object should always drop to the ground initially, and after moving it, when physics is permanently enabled.

Hardware

  • Device: Laptop
  • OS: GNU/Linux
  • Browser: Chromium and Brave

Additional context
Potentially caused by #6487
Originally reported (with slight differences) against the master branch here: #6504

@Exairnous Exairnous added bug needs triage For bugs that have not yet been assigned a fix priority labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage For bugs that have not yet been assigned a fix priority
Projects
None yet
Development

No branches or pull requests

1 participant