From de98d825076d2b782ca8e361802e3919bd61b5fc Mon Sep 17 00:00:00 2001
From: cmathiesen <32553472+cmathiesen@users.noreply.github.com>
Date: Tue, 27 Aug 2019 13:33:30 +0100
Subject: [PATCH] Spotbugs plugin (#32)
* Added spotbugs profile plugin
---
CHANGELOG.md | 7 +++++++
CONTRIBUTING.md | 36 ++++++++++++++++++++++++++++++++++++
pom.xml | 26 ++++++++++++++++++++++----
3 files changed, 65 insertions(+), 4 deletions(-)
create mode 100644 CONTRIBUTING.md
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c5caf39..211f9b7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).
+## [4.2.0] - TBD
+### Added
+- Added `spotbugs-maven-plugin`, version 3.1.12.2.
+### Changed
+- Updated `hotels-oss-plugin-config` version to 1.3.0 (was 1.2.2).
+- Changed `overWrite` to `true` in `maven-dependency-plugin` configuration.
+
## [4.1.0] - 2019-06-27
### Added
- Added a check-for-updates profile which verifies if there are dependencies that can be upgraded.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..91cdd14
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,36 @@
+# How To Contribute
+
+We'd love to accept your patches and contributions to this project. There are just a few guidelines you need to follow which are described in detail below.
+
+## 1. Fork this repo
+
+You should create a fork of this project in your account and work from there. You can create a fork by clicking the fork button in GitHub.
+
+## 2. One feature, one branch
+
+Work for each new feature/issue should occur in its own branch. To create a new branch from the command line:
+```shell
+git checkout -b my-new-feature
+```
+where "my-new-feature" describes what you're working on.
+
+## 3. Add documentation for new or updated functionality
+
+Please review all of the .md files in this project to see if they are impacted by your change and update them accordingly.
+
+## 4. Add to CHANGELOG.md
+
+Any notable changes should be recorded in the CHANGELOG.md following the [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) conventions.
+
+## 5. Submit Pull Request and describe the change
+
+Push your changes to your branch and open a pull request against the parent repo on GitHub. The project administrators will review your pull request and respond with feedback.
+
+# How Your Contribution Gets Merged
+
+Upon Pull Request submission, your code will be reviewed by the maintainers. They will confirm at least the following:
+
+- Tests run successfully (unit, coverage, integration, style).
+- Contribution policy has been followed.
+
+Two (human) reviewers will need to sign off on your Pull Request before it can be merged.
diff --git a/pom.xml b/pom.xml
index 34a169f..bfa8f45 100644
--- a/pom.xml
+++ b/pom.xml
@@ -4,7 +4,7 @@
com.hotels
hotels-oss-parent
- 4.1.1-SNAPSHOT
+ 4.2.0-SNAPSHOT
Parent POM for Hotels.com open source projects
pom
https://github.com/HotelsDotCom/hotels-oss-parent
@@ -45,7 +45,8 @@
4.3.0
2.22.0
3.0.5
- 1.2.2
+ 3.1.12.2
+ 1.3.0
0.8.4
1.8
3.0
@@ -68,6 +69,11 @@
1.6
1.6.8
1.0.0
+
+
+ ${project.build.directory}/plugin-config/findbugs/hotels-findbugs-exclude.xml
+ ${project.build.directory}/plugin-config/spotbugs/hotels-spotbugs-exclude.xml
+ ${project.build.directory}/plugin-config/checkstyle/hotels-checkstyle.xml
@@ -101,7 +107,7 @@
hotels-oss-plugin-config
${hotels.oss.plugin.config.version}
jar
- false
+ true
${project.build.directory}/plugin-config
@@ -188,12 +194,24 @@
${findbugs.config}
+
+ com.github.spotbugs
+ spotbugs-maven-plugin
+ ${spotbugs.maven.plugin.version}
+
+ ${project.build.sourceEncoding}
+ true
+ Max
+ Low
+ ${spotbugs.config}
+
+
org.apache.maven.plugins
maven-checkstyle-plugin
${maven.checkstyle.plugin.version}
- file://${project.build.directory}/plugin-config/checkstyle/hotels-checkstyle.xml
+ ${checkstyle.config}