Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports from Bitcoin #427

Open
6 tasks
CharesFang opened this issue Dec 8, 2021 · 2 comments
Open
6 tasks

Backports from Bitcoin #427

CharesFang opened this issue Dec 8, 2021 · 2 comments

Comments

@CharesFang
Copy link

We recently investigated the Bitcoin issues which are related to privacy protection, vulnerability patches, or security enhancements. We have also checked the repoName source code. Results show that these issues and their PRs are not backported yet. Henceforth, we suggest that repoName should backport the PRs listed below for the considerations of software security and integrity.

  • Bitcoin PR#17906, avoid uninitialized reads.
  • Bitcoin PR#16572, fix a Char variable used as Bool.
  • Bitcoin PR#15039, avoid leaking nLockTime fingerprint.
  • Bitcoin PR#14993, fix data race in InterruptRPC().
  • Bitcoin PR#13808, shuffle coins before grouping, for privacy protection.
  • Bitcoin PR#13683, avoid potential null pointer dereference.

Some of these issues and PRs are not severe security-related, but backports can avoid the chaos ecosystem of Bitcoin-forked projects and the potential vulnerabilities in the future.

Reported by de957ad9679f28a38f02f00cc7928bce8fb424882ff060a3c09c32895b1474cc.

@CharesFang CharesFang changed the title Backprots from Bitcoin Backports from Bitcoin Dec 12, 2021
@CharesFang
Copy link
Author

  • Bitcoin PR#14341 should also be backported from my view. Though I didn't see the completely same functions in Bitcoin-SV (function declaration and its implementations may be different), the way of Bitcoin to handle abnormal Node crash should be referenced.

@CharesFang
Copy link
Author

Bitcoin PR#13907 should also be backported to prevent unlimited growing size of locator, see code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant