Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi word search #19

Open
troyd1000 opened this issue Jan 26, 2021 · 6 comments
Open

Multi word search #19

troyd1000 opened this issue Jan 26, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@troyd1000
Copy link

One thing it seems no one has and that is also with jquery autocomplete is multi word search. Say in your example, if I do bo au ex, it would find anything matching all those words. It is a nice way to whittle down a list matching multiple things. I made updates to your JS to do this. Feel free to implement them to your core if you like.

attached is the updated file.
ac.zip

@Honatas
Copy link
Owner

Honatas commented Jan 27, 2021

@troyd1000 thanks for the time spent with this enhancement, but I'm afraid this is not the correct way to contribute. Opening a zip file is risky, therefore I'm not doing it. If you wish to contribute, please fork the project, add your code and then create a pull request, please.

@Honatas Honatas closed this as completed Jan 27, 2021
@troyd1000
Copy link
Author

troyd1000 commented Jan 27, 2021 via email

@Honatas Honatas reopened this Jan 27, 2021
@Honatas
Copy link
Owner

Honatas commented Jan 27, 2021

It did work!! =)

I'll take a look at it and run some tests as soon as possible.

@Honatas
Copy link
Owner

Honatas commented Jan 28, 2021

@troyd1000 , you have modified the wrong file, the transpiled javascript file. You have to modify the Typescript file.

@troyd1000
Copy link
Author

troyd1000 commented Jan 28, 2021 via email

@Honatas
Copy link
Owner

Honatas commented Jan 28, 2021

Ok, no problem. And thanks again!

I'll keep this issue open in case anyone wants to pick up from where you left.

@Honatas Honatas added the enhancement New feature or request label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants