From d80abbe7c751590926499f23e009c3357b863f90 Mon Sep 17 00:00:00 2001 From: Yusen GAO Date: Sat, 23 Nov 2024 22:15:14 +0800 Subject: [PATCH 1/5] ontime v3.8.0 (new cask) --- Casks/o/ontime.rb | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 Casks/o/ontime.rb diff --git a/Casks/o/ontime.rb b/Casks/o/ontime.rb new file mode 100644 index 000000000000..dc1575124d61 --- /dev/null +++ b/Casks/o/ontime.rb @@ -0,0 +1,28 @@ +# Documentation: https://docs.brew.sh/Cask-Cookbook +# https://docs.brew.sh/Adding-Software-to-Homebrew#cask-stanzas +# PLEASE REMOVE ALL GENERATED COMMENTS BEFORE SUBMITTING YOUR PULL REQUEST! +cask "ontime" do + arch arm: "arm64", intel: "x64" + version "v3.8.0" + sha256 arm: "02f1023bdea737120f4d4f25ab9c841c0dc9ca176bee472241a83038749c7249" + intel: "aebf4d20607bba6016b876fc9bd2e39575fa3db7e98ab99b6b0d7729a943adeb" + + url "https://github.com/cpvalente/ontime/releases/download/#{version}/ontime-macOS-#{arch}.dmg" + verified: "github.com/cpvalente/ontime/" + name "ontime" + desc "Free, open-source time keeping for live events" + homepage "https://getontime.no/" + + # Documentation: https://docs.brew.sh/Brew-Livecheck + livecheck do + url :url + strategy :github_latest + end + + depends_on macos: "" + + app "ontime.app" + + # Documentation: https://docs.brew.sh/Cask-Cookbook#stanza-zap + zap trash: "" +end From 31120ef89945649eb3abe09ab8ba7c8430b58fef Mon Sep 17 00:00:00 2001 From: Yusen GAO Date: Sat, 23 Nov 2024 22:45:02 +0800 Subject: [PATCH 2/5] Remove comments --- Casks/o/ontime.rb | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/Casks/o/ontime.rb b/Casks/o/ontime.rb index dc1575124d61..848447deb0c4 100644 --- a/Casks/o/ontime.rb +++ b/Casks/o/ontime.rb @@ -1,28 +1,24 @@ -# Documentation: https://docs.brew.sh/Cask-Cookbook -# https://docs.brew.sh/Adding-Software-to-Homebrew#cask-stanzas -# PLEASE REMOVE ALL GENERATED COMMENTS BEFORE SUBMITTING YOUR PULL REQUEST! cask "ontime" do arch arm: "arm64", intel: "x64" - version "v3.8.0" - sha256 arm: "02f1023bdea737120f4d4f25ab9c841c0dc9ca176bee472241a83038749c7249" + + version "3.8.0" + sha256 arm: "02f1023bdea737120f4d4f25ab9c841c0dc9ca176bee472241a83038749c7249", intel: "aebf4d20607bba6016b876fc9bd2e39575fa3db7e98ab99b6b0d7729a943adeb" - url "https://github.com/cpvalente/ontime/releases/download/#{version}/ontime-macOS-#{arch}.dmg" + url "https://github.com/cpvalente/ontime/releases/download/v#{version}/ontime-macOS-#{arch}.dmg", verified: "github.com/cpvalente/ontime/" name "ontime" desc "Free, open-source time keeping for live events" homepage "https://getontime.no/" - # Documentation: https://docs.brew.sh/Brew-Livecheck livecheck do url :url strategy :github_latest end - depends_on macos: "" + depends_on macos: ">= :catalina" app "ontime.app" - # Documentation: https://docs.brew.sh/Cask-Cookbook#stanza-zap zap trash: "" end From e59919002ad847751acdf96361447456ef2854d2 Mon Sep 17 00:00:00 2001 From: Yusen GAO Date: Sat, 23 Nov 2024 22:55:46 +0800 Subject: [PATCH 3/5] Enable auto updates --- Casks/o/ontime.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Casks/o/ontime.rb b/Casks/o/ontime.rb index 848447deb0c4..f545c69d89e8 100644 --- a/Casks/o/ontime.rb +++ b/Casks/o/ontime.rb @@ -16,6 +16,7 @@ strategy :github_latest end + auto_updates true depends_on macos: ">= :catalina" app "ontime.app" From 7947aee671f7d09eb2a9235a66924829a293d046 Mon Sep 17 00:00:00 2001 From: Yusen GAO Date: Sat, 23 Nov 2024 22:59:54 +0800 Subject: [PATCH 4/5] Update zap trash with generated by `createzap` --- Casks/o/ontime.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Casks/o/ontime.rb b/Casks/o/ontime.rb index f545c69d89e8..62e3362d7741 100644 --- a/Casks/o/ontime.rb +++ b/Casks/o/ontime.rb @@ -21,5 +21,9 @@ app "ontime.app" - zap trash: "" + zap trash: [ + "~/Library/Application Support/ontime", + "~/Library/Preferences/no.lightdev.ontime.plist", + "~/Library/Saved Application State/no.lightdev.ontime.savedState", + ] end From 113f72ceb385a87df645d04771e745df41d26110 Mon Sep 17 00:00:00 2001 From: Yusen Gao Date: Sun, 24 Nov 2024 11:19:09 +0800 Subject: [PATCH 5/5] Apply suggestions from code review Co-authored-by: Klaus Hipp --- Casks/o/ontime.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Casks/o/ontime.rb b/Casks/o/ontime.rb index 62e3362d7741..bfe601052e13 100644 --- a/Casks/o/ontime.rb +++ b/Casks/o/ontime.rb @@ -7,8 +7,8 @@ url "https://github.com/cpvalente/ontime/releases/download/v#{version}/ontime-macOS-#{arch}.dmg", verified: "github.com/cpvalente/ontime/" - name "ontime" - desc "Free, open-source time keeping for live events" + name "Ontime" + desc "Time keeping for live events" homepage "https://getontime.no/" livecheck do