Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for XRTpy version 0.5 #258

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Changelog for XRTpy version 0.5 #258

wants to merge 25 commits into from

Conversation

joyvelasquez
Copy link
Contributor

Building the changelog for XRTpy version 0.5.

@joyvelasquez joyvelasquez self-assigned this Jun 21, 2024
@joyvelasquez joyvelasquez added the documentation Improvements or additions to documentation label Jun 21, 2024
@joyvelasquez joyvelasquez added this to the 0.5.0 milestone Jun 21, 2024
@namurphy
Copy link
Contributor

Could you delete the files in changelog/ besides README.md?

namurphy
namurphy reviewed Jun 21, 2024
View reviewed changes
docs/changelog/0.5.0.rst Outdated Show resolved Hide resolved
namurphy
namurphy reviewed Jun 21, 2024
View reviewed changes
docs/changelog/0.5.0.rst Outdated Show resolved Hide resolved
joyvelasquez and others added 2 commits June 21, 2024 12:22
namurphy
namurphy reviewed Jun 21, 2024
View reviewed changes
docs/changelog/0.5.0.rst Outdated Show resolved Hide resolved
namurphy
namurphy reviewed Jun 21, 2024
View reviewed changes
docs/changelog/0.5.0.rst Outdated Show resolved Hide resolved
namurphy
namurphy reviewed Jun 21, 2024
View reviewed changes
docs/changelog/0.5.0.rst Outdated Show resolved Hide resolved
namurphy
namurphy reviewed Jun 21, 2024
View reviewed changes
docs/changelog/0.5.0.rst Outdated Show resolved Hide resolved
namurphy
namurphy approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Probably the only things are to make sure the ~sunpy.map.Map link works, and update the links to EffectiveArea and TemperatureResponse. Thank you!

nabobalis
nabobalis reviewed Sep 4, 2024
View reviewed changes
docs/changelog/0.5.0.rst Outdated Show resolved Hide resolved
@nabobalis
Copy link
Member

Missing changes should be (TBD):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namurphy namurphy namurphy approved these changes

@nabobalis nabobalis nabobalis left review comments

Assignees

@joyvelasquez joyvelasquez

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joyvelasquez @namurphy @nabobalis