Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify schedule gives an incorrect error when an invalid input value is provided in task freq field #29

Open
leenaj0hn opened this issue Nov 23, 2018 · 2 comments
Labels
bug Something isn't working Low wontfix This will not be worked on

Comments

@leenaj0hn
Copy link

Provide an incorrect 'task_freq' value eg: give mins field value > 60, and run modify schedule playbook. The below error is displayed

fatal: [localhost]: FAILED! => {
"changed": false,
"invocation": {
"module_args": {
"allow_remote_copy_parent": null,
"base_volume_name": null,
"expiration_hours": 0,
"expiration_time": null,
"expiration_unit": "Hours",
"new_name": null,
"new_schedule_name": "New_Ansible_schedule_01",
"priority": null,
"read_only": null,
"retention_hours": 0,
"retention_time": null,
"retention_unit": "Hours",
"rm_exp_time": null,
"schedule_name": "Ansible_schedule_01",
"snapshot_name": null,
"state": "modify_schedule",
"storage_system_ip": "192.168.67.6",
"storage_system_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"storage_system_username": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"task_freq": "88 * * * *"
}
},
"msg": "Error: An invalid schedule was given: 88 is not a valid value"

@prablr79 prablr79 added the bug Something isn't working label Nov 28, 2018
@sneharai4
Copy link
Contributor

sneharai4 commented Nov 29, 2018

@leenaj0hn @virendra-sharma Currently we are not having validations for each parameter specified in task_freq. As per the documentation, user should provide a value from the below range as specified in the CLI doc.

Field ----> Allowed Values
Minute ----> 0-59
Hour ----> * or 0-23
Day-of-Month ----> * or 1-31
Month ----> * or 1-12
Day-of-Week ----> * or 0-6 (0 is Sunday)

We can mark this bug as a low priority and fix it in later sprint as the error message show above is valid.

@prablr79 prablr79 added the Low label Nov 30, 2018
@sneharai4
Copy link
Contributor

sneharai4 commented Dec 6, 2018

Fix not needed.
@leenaj0hn Please close the issue.

@sneharai4 sneharai4 added the wontfix This will not be worked on label Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Low wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants