Major refactor #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tested new kernel, its OK
different SReD modes now have a parent class. All methods are transported to accessory classes. Two accessory classes were made: CLUtils contains all methods using OpenCL, Utils contains the rest. Need to test block repetition 3D, and all global repetition kernels, but block repetition 2D is tested. This refactor makes the code more readable, more organized, and should allow easier CI.
Fixed incongruences with newer methods in older classes. Classes other than Block repetition and global repetition need improvement.
Added support for 2d block repetition using timeframes
corrected bug where spurious values would be written in borders in kernels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor of the entire codebase. We now have two accessory classes: Utils.Java and CLUtils.Java, which encapsulate all methods used. Utils.Java handles all non-OpenCL methods, and CLUtils.Java handles all OpenCL-based methods.