-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go fmt for formatting go files #164
Comments
I like to work on this. Could you please assign to me @muskankhedia ? |
Hi..I am new to open source and want to start with something simple..could you pls let me know if I can work on this issue? Please do suggest. Thank you. |
@maheshschand Please go ahead. @shivaniraochepuri21 As you are new to open source, please have a look at some easy issues, and go for it. |
@muskankhedia Thanks. I will resolve this issue. |
Hey @maheshschand , any update on this ? |
Hey there, I am going to take a stab at this. I'll have some requests for documentation changes as well as there are no real detailed instructions for contributors, and an error on the main set of instructions. :) This is my very first open source contribution so I'd love as much feedback in the PR as you're willing to give so I can keep learning! |
Pull request #219 added - build failures existed before and unrelated to change - gofmt -l working properly. |
Add a script run at build time that checks Go formatting and fails if it needs formatting.
Made some different changes and got things working properly. Still a couple of unrelated build failures that were present before making changes. |
Thank you @soulclimberchick for the PR. I have merged it as well. Do check the note I wrote as a comment in the PR you submitted. If you need any help related to it, let me know. |
@muskankhedia this issue can be closed. |
Add a condition in Travis CI to check the formatting in go files.
The text was updated successfully, but these errors were encountered: