Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go fmt for formatting go files #164

Open
muskankhedia opened this issue Mar 3, 2020 · 10 comments
Open

Add Go fmt for formatting go files #164

muskankhedia opened this issue Mar 3, 2020 · 10 comments
Labels
beginner Beginner Issue good first issue Good for newcomers gssoc20 Issue for GSSoC-2020

Comments

@muskankhedia
Copy link
Collaborator

Add a condition in Travis CI to check the formatting in go files.

@muskankhedia muskankhedia added good first issue Good for newcomers gssoc20 Issue for GSSoC-2020 beginner Beginner Issue labels Mar 3, 2020
@maheshschand
Copy link

I like to work on this. Could you please assign to me @muskankhedia ?

@shivaniraochepuri21
Copy link

Hi..I am new to open source and want to start with something simple..could you pls let me know if I can work on this issue? Please do suggest. Thank you.

@muskankhedia
Copy link
Collaborator Author

@maheshschand Please go ahead.

@shivaniraochepuri21 As you are new to open source, please have a look at some easy issues, and go for it.

@maheshschand
Copy link

@muskankhedia Thanks. I will resolve this issue.

@ananyaarun
Copy link

Hey @maheshschand , any update on this ?

@soulclimberchick
Copy link
Contributor

Hey there, I am going to take a stab at this. I'll have some requests for documentation changes as well as there are no real detailed instructions for contributors, and an error on the main set of instructions. :) This is my very first open source contribution so I'd love as much feedback in the PR as you're willing to give so I can keep learning!

@soulclimberchick
Copy link
Contributor

Pull request #219 added - build failures existed before and unrelated to change - gofmt -l working properly.

soulclimberchick added a commit to soulclimberchick/Jarvis-personal-assistant that referenced this issue Aug 20, 2020
soulclimberchick added a commit to soulclimberchick/Jarvis-personal-assistant that referenced this issue Aug 20, 2020
Add a script run at build time that checks Go formatting and fails if it
needs formatting.
@soulclimberchick
Copy link
Contributor

Made some different changes and got things working properly. Still a couple of unrelated build failures that were present before making changes.

@Harkishen-Singh
Copy link
Owner

Thank you @soulclimberchick for the PR. I have merged it as well. Do check the note I wrote as a comment in the PR you submitted. If you need any help related to it, let me know.

@Harkishen-Singh
Copy link
Owner

@muskankhedia this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Beginner Issue good first issue Good for newcomers gssoc20 Issue for GSSoC-2020
Projects
None yet
Development

No branches or pull requests

6 participants