Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jarvis Queries and Results UI Change #163

Open
lalitmee opened this issue Mar 3, 2020 · 9 comments
Open

Jarvis Queries and Results UI Change #163

lalitmee opened this issue Mar 3, 2020 · 9 comments
Assignees
Labels
gssoc20 Issue for GSSoC-2020 medium Mudium type issue

Comments

@lalitmee
Copy link
Collaborator

lalitmee commented Mar 3, 2020

Queries and Results Section
Selection_006

We need to come up with some mockups for the same and then we will select the mockup which will be good for the User Experience and will implement that.

Two things to keep in mind:

  • We would prefer it if you can use Figma for creating mockups and when you think you are done, raise the PR with a link of the Figma Mockup.
  • If you like to use any other platform for mockups please do the same thing. Create PR with the mockup.
@muskankhedia muskankhedia added gssoc20 Issue for GSSoC-2020 medium Mudium type issue labels Mar 3, 2020
@algokun
Copy link
Contributor

algokun commented Mar 6, 2020

@muskankhedia could you please assign this issue to me. I would like to work with this one. Also brief the ui details like what are the things you guys are expecting.

@muskankhedia
Copy link
Collaborator

Sure. Go ahead.

@muskankhedia
Copy link
Collaborator

@algokun How is the implementation going?

@algokun
Copy link
Contributor

algokun commented Mar 10, 2020

Yeah. It's going well. I'm redesigning the whole ui. I'll try to submit the ui by today

@algokun
Copy link
Contributor

algokun commented Mar 10, 2020

Here's my the mockup:
https://www.figma.com/file/f7EQz5c7NIDcrPjokapkx3/JarvisAssistant?node-id=0%3A1

Here's the live preview:
https://www.figma.com/proto/f7EQz5c7NIDcrPjokapkx3/JarvisAssistant?node-id=2%3A2&scaling=min-zoom

Can you please tell me what to do next and what to include in PR, the screenshots or actual mockup file?

@muskankhedia
Copy link
Collaborator

@algokun Well Done! You can refer to PR #172 to get an idea on how to create a PR.

@muskankhedia
Copy link
Collaborator

@algokun Please make the PR and submit it asap, else you won't be getting any points for this.

@algokun
Copy link
Contributor

algokun commented Mar 13, 2020

Okay @muskankhedia, i'll submit the pr now.

@muskankhedia
Copy link
Collaborator

@algokun The designs are well made but can you please change the background colour to white and make the combinations accordingly. I missed this point, by mistake, we have planned to keep the background colour as white.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc20 Issue for GSSoC-2020 medium Mudium type issue
Projects
None yet
Development

No branches or pull requests

3 participants