Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvc DLL workaround for templatized members #12

Open
Nic30 opened this issue Mar 6, 2019 · 4 comments
Open

msvc DLL workaround for templatized members #12

Nic30 opened this issue Mar 6, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@Nic30
Copy link
Member

Nic30 commented Mar 6, 2019

The windows DLL build forbids the usage of the templates for members.
This is ridiculous as it says STL can not be used.
And there is probably no workaround.
http://www.unknownroad.com/rtfm/VisualStudio/warningC4251.html
The fact that everything have to be marked manually with dllimport/export is smaller problem.

@Nic30 Nic30 added the help wanted Extra attention is needed label Mar 6, 2019
@XVilka
Copy link

XVilka commented Mar 7, 2019 via email

@XVilka
Copy link

XVilka commented Mar 7, 2019

See https://clang.llvm.org/docs/MSVCCompatibility.html and http://blog.llvm.org/2018/11/30-faster-windows-builds-with-clang-cl_14.html

The LLVM 8.0 release should happen quite soon, matter of days.

In this case there are might be some problems with meson - mesonbuild/meson#4232 and mesonbuild/meson#4232

@Nic30
Copy link
Member Author

Nic30 commented Mar 7, 2019

MSVC out of Visual Studio is complete disaster.
However it is possible to build as a static library.
I try to use clang as it should be much better and it is also used by many.

@Nic30 Nic30 changed the title windows DLL workaround for templatized members msvc DLL workaround for templatized members Mar 8, 2019
@Nic30
Copy link
Member Author

Nic30 commented Mar 23, 2019

And one funny thing, I was thinking that the current windows build does not work because there is some bug in impl. which appears only in windows.

It turns out that mt19937 the random generator works differently under windows so the values in test does not match...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants