Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore base paths in ZResource::GetSourceOutputHeader #15

Open
briaguya-ai opened this issue Oct 25, 2023 · 0 comments
Open

Ignore base paths in ZResource::GetSourceOutputHeader #15

briaguya-ai opened this issue Oct 25, 2023 · 0 comments

Comments

@briaguya-ai
Copy link
Contributor

I clone things to /home/briaguya/code, which fights with

ZAPDTR/ZAPD/ZResource.cpp

Lines 345 to 346 in 3d8a9c1

else if (StringHelper::Contains(xmlPath, "code/"))
prefix = "code";

and adds code to paths where it shouldn't be if pass an absolute path in for inputPath

This was an issue after recent changes in SoH that started using absolute paths. The paths used in SoH have been switched back to relative for now (HarbourMasters/Shipwright#3330) so this isn't urgent, but it would be good to not break if parent paths include any of the strings checked in GetSourceOutputHeader

@briaguya-ai briaguya-ai changed the title Ignore system base paths in ZResource::GetSourceOutputHeader Ignore base paths in ZResource::GetSourceOutputHeader Oct 25, 2023
Archez pushed a commit to Archez/ZAPDTR that referenced this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant