Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [halium-7.1] main.mk: include halium/biometryd #19

Open
wants to merge 1 commit into
base: halium-7.1
Choose a base branch
from
Open

[WIP] [halium-7.1] main.mk: include halium/biometryd #19

wants to merge 1 commit into from

Conversation

konradybcio
Copy link

Without this ninja won't pick up the directory

Change-Id: I453dc369760f82b009ba2191cc8f702c4cc65bd5

Change-Id: I453dc369760f82b009ba2191cc8f702c4cc65bd5
@Herrie82
Copy link

@konradybcio Are you sure you PR-ed this against the correct branch? In order for it to pick up biometryd it should exist as well and therefore be pulled in by https://github.com/Halium/android/blob/halium-7.1/default.xml which it's not doing currently it seems?

@konradybcio
Copy link
Author

I only made the PR as a preparation for that. Biometryd still needs some love on Nougat before we can ship it by default.

@Herrie82
Copy link

@konradybcio OK I will keep it pending for now then. Please link to this PR when you put the necessary bits in place elsewhere.

@Herrie82 Herrie82 changed the title [halium-7.1] main.mk: include halium/biometryd [WIP] [halium-7.1] main.mk: include halium/biometryd Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants