Remove preferences / merge with location setting

[humdingerb]

Currently the only option is to switch between Celsius and Fahrenheit.
IMO Weather should just use the system's locale setting and be done with it.

One could think up other preferences like the refresh frequency, but I'm not a fan of this micro-management. A good default setting should suffice.

If there are actually useful options (maybe selecting the weather service if there are more available), they could all be put in one panel together with the location setting, which is a preference after all.

[ghost]

The locale preferences don't offer any opinion on Temperature units.
This also does not account for the other options available, like Kelvin etc.

[ghost]

Adding this to the same window that picks the locality might be a good idea, so those are a set.
If one uses replicants and intends to travel it may be a better idea to display the foreign city with temperature units that are used there (for example fahrenheit)

[pulkomandy]

The locale preferences don't offer any opinion on Temperature units.

Not yet. But we should add it.

This also does not account for the other options available, like Kelvin etc.

Who uses that? Unless you live on another planet, you don't need them.

If one uses replicants and intends to travel it may be a better idea to display the foreign city with temperature units that are used there

Why? I have no idea about Fahrenheit degrees. It is very annoying when an app insists on using them because it thinks I'm american. Just like when I plan a bike route or a walking path, and the map application decides to use miles for no reason. I want to pick the units I know how to use in my computer, and have these units applied everywhere.

[ghost]

Not yet. But we should add it.

Yes, but these preferences should exist until they are available.

Who uses that? Unless you live on another planet, you don't need them.

Why do these options exist if nobody uses them?

Why? I have no idea about Fahrenheit degrees. It is very annoying when an app insists on using them because it thinks I'm american. Just like when I plan a bike route or a walking path, and the map application decides to use miles for no reason. I want to pick the units I know how to use in my computer, and have these units applied everywhere.

I am in the same boat as you, in that I only think in metric units. Nevertheless it makes sense to allow to opt-in to the local measurements for this stuff, if you intend to travel there and are familiar with the scale this makes it easier to communicate with locals about it. It's more of an edge case really, but to me this makes more sense than the "global" switch since switching everyrthing to fahrenheite seems even more unlikely to me

[pulkomandy]

Why do these options exist if nobody uses them?

Some developer was asked to add Fahrenheit and decided to have a bit of fun and make a kind of statement by adding some other equally silly units there as well. Not everything that's there has an intent that needs to be preserved at all costs.

[nexus6-haiku]

In my branch I intentionally removed all other unit measure and left °C and °F, the only two that make sense on this planet.
Re. system's locale settings: please consider this scenario. Let's assume that I'm Italian but I moved to the US and I have the US local settings. If I want to take a look at the weather in Milan while I'm in the US, chances are that I want to see the temperature in °C. The contrary may also apply. I don't see anything wrong in requesting the forecast in a specific unit measure.
Weather may default to the system settings but I would keep the option to change the display unit regardless.

[ghost]

In my branch I intentionally removed all other unit measure and left °C and °F, the only two that make sense on this planet.

The last commit you have on github has broken fahrenheit, but all the other units are still there and work, unless I am missing something here?

Anyhow. We should probably add this to the locale settings then and make weather use this by default.

[nexus6-haiku]

I have tried on another machine and cloned the Weather repo for the first time and rest assured that all the other units are gone!

[ghost]

Well, I have checkout out your repo, there are no additional commits to pull and i definetely don't see that. Perhaps the makefile is wrong?

[nexus6-haiku]

Could you please check if your local file PreferenceWindow.cpp matches this?

[ghost]

Yes, it matches.
Strangely enough I've deleted the complete objects folders, did a make clean beforehand and it still gave me these options.
After I had deleted the objects folder and the Weather executable again it then worked... Honestly don't know what that was, maybe make was linking in an old compiled object it assumed still matches the file somehow.
Now I don't have the other options anymore.

[humdingerb]

Weather may default to the system settings but I would keep the option to change the display unit regardless.

Fair enough.
I was wondering, there are AFAIK only two official 'everyday' unit systems: °C and °F (and if precipitation were added: mm and inch).
Weather could use the Locale setting (once there) as default and switch metric/imperial when clicking on the temperature view. It'd be a quick and easy way to just quickly switch units temporarily - maybe to convey to your US buddy how hot it is over here.