StreamRadio crashes on launch when built with GCC 8.3 #8

Vidrep · 2019-07-09T18:28:46Z

hrev53233 x86_64
Built Haiku-Radio from source. The app crashes on launch. The version I already had installed does not. Debugger report below:

Debug information for team /boot/home/HaikuArchives/Haiku-Radio/dist/StreamRadio (3560):
CPU(s): 8x Intel Core™ i7-3770
Memory: 15.88 GiB total, 797.00 MiB used
Haiku revision: hrev53233 Jul  5 2019 17:08:51 (x86_64)

Active Threads:
	thread 3563: team 3560 debug task 
	thread 3560: StreamRadio (main)
		state: Exception (Segment violation)

		Frame		IP			Function Name
		-----------------------------------------------
		0x7fd6313927a0	0x1f99b7fc760	BEntry::GetStat(stat*) const@@LIBBE_1_ALPHA1 + 0 
			Disassembly:
				BEntry::GetStat(stat*) const@@LIBBE_1_ALPHA1:
				0x000001f99b7fc760:           8b4728  mov 0x28(%rdi), %eax <--

			Frame memory:
				[0x7fd631392798]  ........   b0 c7 7f 9b f9 01 00 00
		0x7fd631392850	0x1f99b7fc7ab	BEntry::_GetStat(stat_beos*) const + 0x1b 
		0x7fd631392a30	0xb392f68177	_Unwind_ForcedUnwind_Phase2(_Unwind_Exception*, _Unwind_Context*, long unsigned int*) + 0x57 (/sources/gcc-8.3.0/libgcc/unwind.inc:-1)
			Variables:
			exc: 0x1f99bae56b0 {
				exception_class: 2171567323184
				exception_cleanup: 0x1f99b7fb860
				private_1: 2171567327120
				private_2: 2171567327072
			}
			context: 0x7fd631392b30 {
				reg: Unavailable
				cfa: 0x7fd631392c70
				ra: 0x19704367146
				lsda: 0x197043788fa
				flags: 4611686018427387904
				version: 0
				args_size: 0
				by_value: 
			}
			frames_p: 0x7fd631392a38 {
				*frames_p: 140557925559088
			}
			stop: 0x1f99b7fc790
			stop_argument: 0x1f99b7fc760 {
				*stop_argument: Unavailable
			}
			code: _URC_NO_REASON
			frames: 1
			fs {
				pc: 0x1970436712e
				personality: 0xc625853910
				data_align: -8
				code_align: 1
				retaddr_column: 16
				fde_encoding: 27
				lsda_encoding: 27
				saw_z: 1
				signal_frame: 0
				eh_ptr: 0
			}
			action: 652

		0x7fd631392c60	0xb392f68990	_Unwind_Resume + 0x180 
		0x7fd631392d10	0x19704367146	_ZN12StationsList4SaveEv.cold.8 + 0 
		0x7fd631392e60	0x1970436b05a	RadioSettings::Load() + 0xca 
		0x7fd631392e90	0x1970436b0bf	RadioSettings::RadioSettings() + 0x3f 
		0x7fd631392eb0	0x1970436a78b	RadioApp::RadioApp() + 0x2b 
		0x7fd631392ed0	0x19704367e71	main + 0x21 
		0x7fd631392f00	0x197043681c9	_start + 0x39 
		0x7fd631392f30	0x208401fc573	runtime_loader + 0x103 
		00000000	0x7fce18ea6260	commpage_thread_exit + 0

The text was updated successfully, but these errors were encountered:

Vidrep · 2019-07-09T18:47:24Z

@jsteinaker

jsteinaker · 2019-07-09T20:56:29Z

It's not crashing here. I've uploaded a new HaikuPorts recipe a few hours ago, which doesn't use the patchset anymore, since the changes that were there are already merged on the tree. It's not merged yet but you should be able to get it anyway. Starting with that recipe only I can sucessfully build StreamRadio, downloading the sources from GitHub, and it doesn't crash. I was thinking that maybe the patch (if you're using it) is breaking something...

Also, it seems the crash is coming from the Load method in Radio Settings class. I haven't changed anything there. Save() method now calls Rewind(), so it actually deletes a Station when asked, but that method shouldn't be called on startup anyway. Did you try deleting your "Stations" folder?

Thanks for reporting!

EDIT: same exact hrev and arch here. Waaaaaay less memory, inside VirtualBox.

Vidrep · 2019-07-09T23:21:23Z

Did you test on 64 bit? I also built from the new recipe, and it also crashes (same as above). I tried deleting the "stations" folder too. Same.
Previously installed version works OK.

jsteinaker · 2019-07-10T05:12:32Z

Yes, I'm on x64. It would be great if more people could try building the new version to see what happens.

humdingerb · 2019-07-10T05:48:13Z

c983b6e works on 32bit (hrev53209).

diversys · 2019-07-10T08:39:41Z

c983b6e crashes on 64bit (hrev53233)

jsteinaker · 2019-07-10T17:20:03Z

Just downloaded last 64bit nightly (hrev53237) to start the build absolutely from scratch. Works fine here.

Maybe a stupid idea but... how much memory do you guys have? Real hardware or VM? The main difference between your setup and mine that I can think of it's this one, I'm on a VM with only 2-3gb of RAM...

waddlesplash · 2019-07-10T22:03:55Z

Try using the guarded heap, it's possible some slight difference is triggering memory corruption which the guarded heap should catch.

jsteinaker · 2019-07-10T22:58:42Z

Do you mean this?
https://www.haiku-os.org/blog/mmlr/2010-02-08_using_malloc_debug_find_memory_related_bugs/

Also, what about the while condition check line in the Load() method in RadioSettings.cpp? I'm taking about operator precedence, I guess that might be wrong but I can't check now

Vidrep · 2019-07-10T23:00:47Z

Built on real hardware. x86_64 Core i7-3770, 16GB memory

waddlesplash · 2019-07-10T23:01:45Z

Yes, you'll want the guarded heap though, so in addition to the LD_PRELOAD, add MALLOC_DEBUG=g also.

Vidrep · 2019-07-11T03:37:07Z

Running the following: LD_PRELOAD=libroot_debug.so MALLOC_DEBUG=g StreamRadio

``
Debug information for team /boot/system/apps/StreamRadio (920):
CPU(s): 8x Intel Core™ i7-3770
Memory: 15.88 GiB total, 624.45 MiB used
Haiku revision: hrev53233 Jul 5 2019 17:08:51 (x86_64)

Active Threads:
thread 923: team 920 debug task
thread 920: StreamRadio (main)
state: Call (abort() called)

	Frame		IP			Function Name
	-----------------------------------------------
	00000000	0x2095f3a9e7f	_kern_debugger + 0x7 
		Disassembly:
			_kern_debugger:
			0x000002095f3a9e78:   48c7c0e1000000  mov $0xe1, %rax
			0x000002095f3a9e7f:             0f05  syscall  <--

	0x7feee7ffa770	0x2095f3a1cc3	abort + 0x4a 
	0x7feee7ffa9b0	0x1326f918773	__absvdi2(DItype) + 0x73 (/sources/gcc-8.3.0/libgcc/libgcc2.c:-1)
	0x7feee7ffaa50	0x1d8ba1f4146	_ZN12StationsList4SaveEv.cold.8 + 0 
	0x7feee7ffaba0	0x1d8ba1f805a	RadioSettings::Load() + 0xca 
	0x7feee7ffabd0	0x1d8ba1f80bf	RadioSettings::RadioSettings() + 0x3f 
	0x7feee7ffabf0	0x1d8ba1f778b	RadioApp::RadioApp() + 0x2b 
	0x7feee7ffac10	0x1d8ba1f4e71	main + 0x21 
	0x7feee7ffac40	0x1d8ba1f51c9	_start + 0x39 
	0x7feee7ffac70	0x99501c3573	runtime_loader + 0x103 
	00000000	0x7fff3d81d260	commpage_thread_exit + 0

``

diversys · 2019-07-11T09:52:29Z

I'just built 26f3bbd and it crashes with the same back trace.

diversys · 2019-07-11T10:35:28Z

Also built current version from haikuports (after commenting out PATCHES) and it has the same problem.

jsteinaker · 2019-07-11T18:05:17Z

Thank you all for the feedback.

I ran StreamRadio using malloc_debug=g. It did not crash on startup. BUT, it crashed when doing a search, so I've just fixed that on my repo.

However, if you double-click on an empty space on the stations list on the main window, it crashes (with or without malloc_debug=g). It might be related to fishpond-haiku/Haiku-Radio#4 and I guess it might be related to the crash you're experiencing as well.

I'll keep further investigating this.

diversys · 2019-07-11T18:09:00Z

Still crashes with your fix applied.

diversys · 2019-07-11T18:14:20Z

MALLOC_DEBUG=g StreamRadio

jsteinaker · 2019-07-11T20:20:32Z

Well, that was... ¿expected? The crash I fixed was apparently a different one.

I've just fixed the one happening when double-clicking the main window. Not that should fix the crash you're experiencing on startup, since I can't reproduce that one, even with MALLOC_DEBUG=g (and MALLOC_DEBUG it's working, cause I wasn't seeing the first crash I've fixed before enabling the flag). I'll keep looking around the code in your screenshot.

Again, thanks for the feedback, it's much appreciated.

jsteinaker · 2019-07-11T20:31:44Z

A couple of lines before the line marked in your screenshot, when casting to (BGroupLayout*), there's a space that shouldn't be there between BGroupLayout and the * character... could be this? I've tried it and it compiles and works OK, but I wasn't experiencing the crash in first place so I can't tell...

diversys · 2019-07-11T20:49:33Z

With your new fix and with space removed it still crashes as before. In release mode as in description and in debug mode in MainWindow.cpp. Have you tried make clean and rebuilding again?

Vidrep · 2019-07-11T20:58:37Z

How about a real time discussion on IRC at #haiku-3rdparty

jsteinaker · 2019-07-11T21:00:10Z

Just did it, same result, works fine here (I even started with a fresh virtual machine and different hrev at some point)

@Vidrep I'm leaving now, but I'm up for that at a different moment.

diversys · 2019-07-11T21:02:51Z

What gcc version do you use? Note, that by default it is still gcc7 now.

waddlesplash · 2019-07-11T21:16:09Z

Huh? No, we are using GCC8?

diversys · 2019-07-11T21:47:59Z

anyboot images still have gcc7 by default I believe.

jsteinaker · 2019-07-11T22:11:29Z

Will check later, but definitely whatever is on latest x64 nightly anyboot by default

jsteinaker · 2019-07-12T18:27:35Z

gcc 7.3.0 here

diversys · 2019-07-12T19:29:43Z

So, can you try with gcc8?

jsteinaker · 2019-07-13T06:10:19Z

Updated to gcc-8.3.0, make clean, recompiled. Aaaaaand we have a crash on startup, finally.
Also, A LOT more warnings during compilation (it was only throwing a small one with gcc7).

I guess I should start reading them, but that's a different story. Any pointers in the right direction are very welcome. If anyone wants to try the changes in StreamRadio in the meantime, gcc7 is the answer.

jsteinaker · 2019-07-14T01:01:55Z

Ok, the warnings and runtime errors were related and fortunately the fixes were easy. Can you please try them? I've already made a pull request, I'll make another for the haikuports tree as soon as this one is approved.

diversys · 2019-07-14T08:22:08Z

Thanks! It release version doesn't crash anymore in 9d387c7.
However, it still crashes when compiled with DEBUGGER := TRUE.

jsteinaker · 2019-07-14T15:38:35Z

Great. I'll keep investigating the matter. Should we close this? (Or maybe change the subject to reflect the crash was about the transition to gcc8, and not about the changes made). Thanks!

Vidrep · 2019-07-14T21:01:17Z

StreamRadio now launching without a crash when built with gcc8.3. Closing as fixed. Thank you for looking into this issue!

Vidrep changed the title ~~StreamRadio crash on launch since last commits~~ StreamRadio crash on launch since last commits by jsteinaker Jul 9, 2019

waddlesplash mentioned this issue Jul 10, 2019

Streamradio patch haikuports/haikuports#3973

Merged

diversys changed the title ~~StreamRadio crash on launch since last commits by jsteinaker~~ StreamRadio crashes on launch when built with GCC 8.3 Jul 14, 2019

Vidrep closed this as completed Jul 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

StreamRadio crashes on launch when built with GCC 8.3 #8

StreamRadio crashes on launch when built with GCC 8.3 #8

Vidrep commented Jul 9, 2019 •

edited by diversys

Loading

Vidrep commented Jul 9, 2019

jsteinaker commented Jul 9, 2019 •

edited

Loading

Vidrep commented Jul 9, 2019

jsteinaker commented Jul 10, 2019

humdingerb commented Jul 10, 2019

diversys commented Jul 10, 2019

jsteinaker commented Jul 10, 2019

waddlesplash commented Jul 10, 2019

jsteinaker commented Jul 10, 2019

Vidrep commented Jul 10, 2019

waddlesplash commented Jul 10, 2019

Vidrep commented Jul 11, 2019 •

edited by diversys

Loading

diversys commented Jul 11, 2019

diversys commented Jul 11, 2019 •

edited

Loading

jsteinaker commented Jul 11, 2019

diversys commented Jul 11, 2019

diversys commented Jul 11, 2019

jsteinaker commented Jul 11, 2019 •

edited

Loading

jsteinaker commented Jul 11, 2019

diversys commented Jul 11, 2019

Vidrep commented Jul 11, 2019

jsteinaker commented Jul 11, 2019

diversys commented Jul 11, 2019 •

edited

Loading

waddlesplash commented Jul 11, 2019

diversys commented Jul 11, 2019

jsteinaker commented Jul 11, 2019

jsteinaker commented Jul 12, 2019

diversys commented Jul 12, 2019

jsteinaker commented Jul 13, 2019

jsteinaker commented Jul 14, 2019

diversys commented Jul 14, 2019

jsteinaker commented Jul 14, 2019

Vidrep commented Jul 14, 2019

StreamRadio crashes on launch when built with GCC 8.3 #8

StreamRadio crashes on launch when built with GCC 8.3 #8

Comments

Vidrep commented Jul 9, 2019 • edited by diversys Loading

Vidrep commented Jul 9, 2019

jsteinaker commented Jul 9, 2019 • edited Loading

Vidrep commented Jul 9, 2019

jsteinaker commented Jul 10, 2019

humdingerb commented Jul 10, 2019

diversys commented Jul 10, 2019

jsteinaker commented Jul 10, 2019

waddlesplash commented Jul 10, 2019

jsteinaker commented Jul 10, 2019

Vidrep commented Jul 10, 2019

waddlesplash commented Jul 10, 2019

Vidrep commented Jul 11, 2019 • edited by diversys Loading

diversys commented Jul 11, 2019

diversys commented Jul 11, 2019 • edited Loading

jsteinaker commented Jul 11, 2019

diversys commented Jul 11, 2019

diversys commented Jul 11, 2019

jsteinaker commented Jul 11, 2019 • edited Loading

jsteinaker commented Jul 11, 2019

diversys commented Jul 11, 2019

Vidrep commented Jul 11, 2019

jsteinaker commented Jul 11, 2019

diversys commented Jul 11, 2019 • edited Loading

waddlesplash commented Jul 11, 2019

diversys commented Jul 11, 2019

jsteinaker commented Jul 11, 2019

jsteinaker commented Jul 12, 2019

diversys commented Jul 12, 2019

jsteinaker commented Jul 13, 2019

jsteinaker commented Jul 14, 2019

diversys commented Jul 14, 2019

jsteinaker commented Jul 14, 2019

Vidrep commented Jul 14, 2019

Vidrep commented Jul 9, 2019 •

edited by diversys

Loading

jsteinaker commented Jul 9, 2019 •

edited

Loading

Vidrep commented Jul 11, 2019 •

edited by diversys

Loading

diversys commented Jul 11, 2019 •

edited

Loading

jsteinaker commented Jul 11, 2019 •

edited

Loading

diversys commented Jul 11, 2019 •

edited

Loading