Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning to file format #540

Open
dsizzle opened this issue Jun 3, 2023 · 5 comments
Open

Add versioning to file format #540

dsizzle opened this issue Jun 3, 2023 · 5 comments
Labels
enhancement file-handling issues related to file handling

Comments

@dsizzle
Copy link
Collaborator

dsizzle commented Jun 3, 2023

ArtPaint currently has no versioning for the project files. It would be useful to have when there is an inevitable breaking change to the format so that users can be alerted to incompatibilities rather than either crashing or silently ignoring parts of a file.

@humdingerb
Copy link
Member

Is this something to be looked into before the next release introducing compressed layer data?

@dsizzle
Copy link
Collaborator Author

dsizzle commented Jul 3, 2023

I hadn’t planned to tackle this right away. If you’re concerned about the compression I can just disable it easily.

(It is as simple as changing the “ZLIB_COMPRESSION” to “NO_COMPRESSION” in Image::WriteLayers)

@humdingerb
Copy link
Member

If you don't see a problem, I'd rather keep the compression if possible.
I suppose in the future, if ArtPaint happens on an unversioned project file, it can assume it to be from an ArtPaint <= v2.6 (our upcoming release).

@dsizzle
Copy link
Collaborator Author

dsizzle commented Jul 3, 2023

I worry about an unrecoverable file corruption with the compression that we haven’t run across yet, just because the compression part is relatively new.

@humdingerb
Copy link
Member

What better opportunity to widen our pool of testers? :)
If people encounter related showstoppers that you can't fix quickly, we can revert to uncompressed and do a quick point release.

@dsizzle dsizzle added enhancement file-handling issues related to file handling labels Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement file-handling issues related to file handling
Development

No branches or pull requests

2 participants