Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font-display used in the wrong places? #92

Open
sersorrel opened this issue Nov 27, 2019 · 1 comment
Open

font-display used in the wrong places? #92

sersorrel opened this issue Nov 27, 2019 · 1 comment
Labels
frontend Relating to the HTML, CSS, and JS which runs in the user's browser good first issue

Comments

@sersorrel
Copy link
Member

Chrome 73 is complaining at me that it doesn't know what font-display means:

image

but I think what it actually means is that font-display is only valid inside an @font-face.

  • is this actually the case?
  • if so, how do we reconcile that with the fact that our @font-faces come from Google Fonts?
@LukeMoll
Copy link
Member

LukeMoll commented Jan 5, 2020

I think I added the font-display code, if that is the case (very well may be) then it can be fixed by adding &display=swap to the Google Fonts URL

Either I or someone else can take a look at that at some point, should be a straightforward investigation and action.

@LukeMoll LukeMoll added the frontend Relating to the HTML, CSS, and JS which runs in the user's browser label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Relating to the HTML, CSS, and JS which runs in the user's browser good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LukeMoll @sersorrel