Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluous titles in RSS feeds #194

Open
LukeMoll opened this issue Jan 6, 2022 · 3 comments
Open

Superfluous titles in RSS feeds #194

LukeMoll opened this issue Jan 6, 2022 · 3 comments
Labels
backend Relating to the code which runs on the server and generates the site bug Unexpected behaviour on client or server side Needs clarification Issue author should provide more information or clarification requested in comments.

Comments

@LukeMoll
Copy link
Member

LukeMoll commented Jan 6, 2022

Screenshot showing every article ending in - HackSoc - The Computer Science Society

It is unconventional for RSS articles to give the site's title in the article title, as there is a separate field to indicate that (here "HackSoc News").

Since the suffix is fixed and known, a heuristic approach could be to call removesuffix("- HackSoc - The Computer Science Society") when templating into the RSS feed.

In fact, the suffix is never appended to the title variable, so it is unexpected that it should show up in the feed. Additionally, it is not every article, as the article about libera.chat is unaffected.

It is entirely possible this issue is caused by unexpected behaviour on the feed reader, further investigation is warranted.

@LukeMoll LukeMoll added Needs clarification Issue author should provide more information or clarification requested in comments. bug Unexpected behaviour on client or server side backend Relating to the code which runs on the server and generates the site labels Jan 6, 2022
@LukeMoll
Copy link
Member Author

LukeMoll commented Jan 7, 2022

This seems to be caused wholly by the feed reader (in this case Chrome) as these issues are not present in the raw feed. This is possibly not fixable or out-of-scope for this repository.

@JMAlego
Copy link
Member

JMAlego commented Mar 8, 2022

I can confirm I have no such issue in my RSS reader - which makes sense as that's the one I was testing with when developing the feed - so it does seem to be specific to your reader.

image

I realise this is a "not on my machine" style comment so sorry about that 😅

@LukeMoll
Copy link
Member Author

LukeMoll commented Mar 8, 2022

I should add some reproduction notes - this was using the Chrome RSS reader, gated behind feature flags at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Relating to the code which runs on the server and generates the site bug Unexpected behaviour on client or server side Needs clarification Issue author should provide more information or clarification requested in comments.
Projects
None yet
Development

No branches or pull requests

2 participants