Clean Build for 2019 #2347
Clean Build for 2019 #2347
Conversation
|
Hmmm.... interesting. I'm seeing errors running the AllReady.ScenarioTest locally. I'm going to spend some time investigating. |
|
Appveyor appears to have had some sporadic issues restoring npm packages. This caused some non-reproducible failures. They seemed to have been resolved by the end of today. Examination of the output from Appveyor indicated that is was using Gulp 4.0. So I updated gulpfile.js to be compatible. This worked locally. As for the integration test, the local chromedriver version was 2.33 while appveyor was using 2.45. So local results didn't match up. I think I have a stable fix for that after a couple of hours of trial and error. |
| @@ -12,6 +12,7 @@ | |||
| "gulp-cssmin": "0.1.7", | |||
| "gulp-sourcemaps": "1.6.0", | |||
| "gulp-typescript": "3.1.5", | |||
| "natives": "1.1.6", | |||
There was a problem hiding this comment.
I read some of the notes and warnings about this package behaving differently on different versions of NodeJS.
There was a problem hiding this comment.
I ran across the same but I think the best long term solution is simply move to Gulp 4.0. I’ve got a separate PR for that in the pipeline. Decided it was better to piecemeal out things.
There are a lot of packages. Not sure if they are all being used either. NPM audit shows a bunch of stuff well above my pay grade :)
oneolddev
force-pushed
the
CleanBuild2019
branch
from
4669a8d to
05c256e
Compare
|
I'm closing this PR. Why?
|
I attempted to rebuild the web only portion of the allReady on a fresh development system and encountered multiple build issues. This PR should resolve #2343(#2344, #2345, #2346)