Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread Irish-language strings #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rodoch
Copy link

@rodoch rodoch commented Jul 7, 2020

This PR fixes a small number of clear issues with the Irish-language text in the COVID tracker app. No one, including myself, has ever launched an app without some typos, and the Irish used in the app is quite good (and we all need a proofreader), so I'm not trying to be pedantic. However, there are excellent Irish-language resources out there that can prevent these issues and Irish speakers deserve the same consistent professional quality as is evident throughout the rest of the app.

Here are a few illustrative examples of the proposed changes:

Inappropriate language domain

"dismiss": "Dífhostú"

'Dífhostú' is used in relation to dismissal from employment. 'Ruaig' (get rid of, hide) is the correct term in this context.

Incorrect terminology

"contactTracing": "Rianú Teagmhála"

The correct term, as per The National Terminology Database for Irish, is "Rianú Teagmhálaithe".

Grammatical errors

"uploadKeys": "Uaslódáil d'Eochracha Randamach",

Proper noun-adjective agreement calls for the plural form 'Randamacha' here.

Typos

"warning": "Ba mhaith linn go dtabharfá nios mó aire duit féin chun tú a chosaint ar an choróinvíreas, de bharr d'aois.\n\nTá daoine atá níos sine agus daoine a bhfuil tinnis fadthéarmacha orthu i mbaol níos mó tinneas tromchúiseach a fháil ón COVID-19.",

'Nios' here is missing a síneadh fada ('níos'). 'Fadtéarmach(a)' is the correct spelling for long-term.


I have committed these changes to assets/lang/ga.json. The lang directory contains another file ie.json but this appears to be redundant; it is not imported by services/i18n/common.tsx in any case.

Go raibh maith agaibh!

@jasnell
Copy link

jasnell commented Jul 28, 2020

/cc @colmharte

jasnell added a commit to jasnell/covid-tracker-app that referenced this pull request Jul 28, 2020
@colmharte
Copy link
Member

@rodoch Thanks for the review and feedback on the Irish language. There is a overall review of the Irish language within the app and will feed these changes into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants