Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hsa_ext_program_finalize_directive_mismatch is undefined #5

Open
pjaaskel opened this issue Nov 12, 2016 · 0 comments
Open

hsa_ext_program_finalize_directive_mismatch is undefined #5

pjaaskel opened this issue Nov 12, 2016 · 0 comments

Comments

@pjaaskel
Copy link

pjaaskel commented Nov 12, 2016

There's a problematic testing being here:

http://github.com/HSAFoundation/HSA-Runtime-Conformance/blob/master/src/extensions/ext_api/test_hsa_ext_program_finalize.c#L414

First, the kernel in question does not define required_dim so there is not a mismatch, second, the illegal dimension 4 seems not to be defined in the specs, and finally the hsa_ext_control_directives_t contro_directive_mask is not used to enable that directive. Thus, I belive in this case the call should pass succesfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant