You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems ncos (and other native fp instructions) are very vaguely specified regarding their accuracy. However, at least ncos tests assume something of the result rounding. When implementing ncos with libm cosf(), there's a failure:
The tested input value for [5] is -1.57079637. Because the specs is so vague of the accuracy of these instructions, I do not immediately know how to fix these tests as there doesn't seem to be accompanying runtime API to queries for asking the Agent specific accuracy either.
The text was updated successfully, but these errors were encountered:
Runtime API query for this looks like overkill. Perhaps it is worth to change comparison mode from "ulps" (which can yield enormously big diff) to "relative", with quite relaxed precision requirement, so the test will perform very rude assessment of ncos/nsin. Another option is to exclude nsin/ncos from testing unless explicitly specified by command-line option (together with expected precision).
It seems ncos (and other native fp instructions) are very vaguely specified regarding their accuracy. However, at least ncos tests assume something of the result rounding. When implementing ncos with libm cosf(), there's a failure:
The tested input value for [5] is -1.57079637. Because the specs is so vague of the accuracy of these instructions, I do not immediately know how to fix these tests as there doesn't seem to be accompanying runtime API to queries for asking the Agent specific accuracy either.
The text was updated successfully, but these errors were encountered: