-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fragment with status of last build #219
Comments
How could the current build possibly know that the last build failed? |
checking the presense of e.g. http://build.fhir.org/ig/WorldHealthOrganization/smart-anc/failure/build.log or something? |
The template can't add a fragment, so this is in the wrong place |
Also, I don't understand how this is useful. if this build succeeds, why does it matter whether the last build failed? |
The scenario where this is useful is when the build does not succeed - the current page (previous build) should show this somehow |
First, don't have a clue how the 'somehow' would work |
this change is precisely for when one of the people making changes does not check the Zulip stream for one change, or when they cannot fix it, or for non-committers to see the status. If the build gets broken, non-committers will be looking at a broken build without knowing, and the next committers may presume it's their commit that breaks things. |
If you have multiple committers, then you might want to look at putting in merge blocking that prevents unsuccessful commits from merging to the master. Non-committers won't be looking at a broken build - they'll be looking at the last successful build. They'll have no idea there are pending changes they don't yet see, and that's probably fine. That's what a CI-build is... |
When looking at an IG, we know it's built ok but we have no idea if the last build failed.
Can we add a fragment that templates can optionally display - next to the publish box? - and show something like
"This spec is up to date" or "The last build failed"... (text tbd)
The text was updated successfully, but these errors were encountered: