Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: retry fetching page #79

Open
brbog opened this issue Jun 7, 2022 · 1 comment
Open

feature request: retry fetching page #79

brbog opened this issue Jun 7, 2022 · 1 comment

Comments

@brbog
Copy link

brbog commented Jun 7, 2022

During tests I observed a couple of times that a fetch failed due to 0 bytes being returned from the server. Since it was not deterministic, a simple "retry" could probably work, but there is currently no way to get that behavior.

The "magic" happens inside the private WebCrawler.processPage()-method. When requesting a retry after fetchResult = pageFetcher.fetchPage(curURL); was performed, the rest of the logic should also still be executed.

@brbog
Copy link
Author

brbog commented Jun 7, 2022

Just raising this as a possible improvement for anyone who wants to contribute something :-). Creating a good test for this (using WireMock?) is rather important, but requires some effort I currently can't commit to :-(.

@rzo1 rzo1 added this to the v5.0.3 milestone May 23, 2023
@rzo1 rzo1 modified the milestones: v5.0.3, v5.1.1 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants