-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a (proper) logger #12
Comments
I would like to contribute. Is there a guide on how to setup the project so I can test my changes? |
For example the program wants a config file which apparently holds the api key but I think it would be helpful if there was an easy to read guide that would explain how the program is set up and what said config file expects. |
I haven't yet written a contribution guide, but I'm planning on doing so. You should be able to build the project by simply cloning the repo and opening it in Visual Studio, the only thing requiring manual setup is the A basic configuration file looks like this:
You can acquire the token on the Discord Developers site, after creating your application (see the The rest of the values can be safely ignored, as they're optional. |
Well thanks a lot for the explanation, I will try and set up everything in the next few days and then try to commit to some of the issues :D |
If I understand correctly, you need to configure a logger. In this case, I suggest using Serilog (I am familiar with it, so I can quickly fix this problem. If the library suits you, then I suggest choosing which type of data recording interests you. |
@BloodyMilchShake, we can try to do this together. Cool experience 😊 |
I was originally planning to write my own basic logger, but it's probably not worth it now that I'm thinking about it :P After looking into the library, I think it should fit well, so you can work on it if you want :) |
Sure thing :) |
A few questions: And is it worth adding detailed logs?
|
@BloodyMilchShake, then I will start developing on my fork of this repository. I will be waiting for your contribution. If you will have any questions/suggestions, you can write to me by email. |
I have set up the logger, but I can't test it. It turns out that in addition to config.oson, you also need the ffmpeg.exe file. If possible, provide more detailed information about installing and running the application. I'm ready to upload a commit with a logger, I'm waiting for your opinion and email to indicate it as co-author @BloodyMilchShake! |
It seems I've forgotten to mention that You can install ffmpeg on windows by using winget: I'm also going to add a check for ffmpeg, so the program logs a helpful error message on start if it can't detect ffmpeg when you add the logger |
No description provided.
The text was updated successfully, but these errors were encountered: