Add check for PERL_FOUND around actual test #5130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 2. Medium ⏹
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
approved these changes
Nov 19, 2024
|
I wish there were a portable way of doing this without the Perl dependency |
|
You don't need Perl for this test, though. The test will run fine if the system's date command takes %s (true on Linux and Mac, but not some oddballs like Solaris). Also, this doesn't have a Powershell equivalent and doesn't get tested on Windows. We should add GitHub issues for anything that is tested under Linux but not Windows due to no Powershell equivalent. |
|
However -the .sh file is not created earlier so cannot execute the test. |
lrknox
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Skip H5SHELL-test_flush_refresh Test for CMake #4394