From 68cecdb9674e84bcdf35460691a4e0948c2392d4 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Fri, 22 Sep 2023 17:08:50 -0500 Subject: [PATCH 1/2] removed the use of -commons linking option on Darwin as COMMON and EQUIVALENCE is no long used --- configure.ac | 8 -------- fortran/src/H5_ff.F90 | 2 -- 2 files changed, 10 deletions(-) diff --git a/configure.ac b/configure.ac index 15f7bb4e69e..37252d9a76a 100644 --- a/configure.ac +++ b/configure.ac @@ -1074,14 +1074,6 @@ H5_FORTRAN_SHARED="no" if test "X${HDF_FORTRAN}" = "Xyes" && test "X${enable_shared}" != "Xno"; then AC_MSG_CHECKING([if shared Fortran libraries are supported]) H5_FORTRAN_SHARED="yes" - ## tell libtool to do the right thing with COMMON symbols, this fixes - ## corrupt values with COMMON and EQUIVALENCE when building shared - ## Fortran libraries on OSX with gnu and Intel compilers (HDFFV-2772). - case "`uname`" in - Darwin*) - H5_LDFLAGS="$H5_LDFLAGS -Wl,-commons,use_dylibs" - ;; - esac ## Report results of check(s) diff --git a/fortran/src/H5_ff.F90 b/fortran/src/H5_ff.F90 index 7bd2e261929..68b3dd874bb 100644 --- a/fortran/src/H5_ff.F90 +++ b/fortran/src/H5_ff.F90 @@ -12,8 +12,6 @@ ! PURPOSE ! This module is used to pass C stubs for H5 Fortran APIs. The C stubs are ! packed into arrays in H5_f.c and these arrays are then passed to Fortran. -! This module then uses EQUIVALENCE to assign elements of the arrays to -! Fortran equivalent C stubs. ! ! NOTES ! The size of the C arrays in H5_f.c has to match the values of the variables From 3d2a15c83d6508052732ffebf36fde49016a97ca Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 25 Sep 2023 14:05:12 -0500 Subject: [PATCH 2/2] added release note --- release_docs/RELEASE.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index fa088951d89..0e1dbe42b3b 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -261,6 +261,11 @@ New Features h5pget_file_space_page_size_f, h5pset_file_space_page_size_f, h5pget_file_space_strategy_f, h5pset_file_space_strategy_f + - Removed "-commons" linking option on Darwin, as COMMON and EQUIVALENCE + are no longer used in the Fortran source. + + Fixes GitHub issue #3571 + C++ Library: ------------ -