Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially incorrect logic in run_container in docker_master.py (worker) #21

Open
Snapple49 opened this issue Feb 7, 2019 · 0 comments

Comments

@Snapple49
Copy link

When attempting to create container the method checks the result Docker API client function containers.run() (here and here ) to see if it exists, and if it does declares the creation successful. However if an error occured it may still exist while the container was not created, see example output from worker:

starting container snapple49/hio-tester:cpu50time60
..created container, logs:
b'Traceback (most recent call last):\n  File "example.py", line 1, in <module>\n    from harmo
nicPE.daemon import listen_for_tasks\n  File "/usr/local/lib/python3.6/site-packages/harmonicP
E/daemon.py", line 73\n    if not Setting.get_idle_timeout() == None\n                        
                    ^\nSyntaxError: invalid syntax\n'
[OUT: Container snapple49/hio-tester:cpu50time60 is created!]
[OUT: Container snapple49/hio-tester:cpu50time60 is created ]

Maybe better to check that status of result is running or something like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant