-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flattening workbook view data #34
Comments
Ps. sorry for not replying to the other issue, I forgot about it. The tap is and has been working very well for us since we started using it this year. We are starting to pull more data entities right now |
Hey @Ahaberling - do you mean flattening it out into a child stream? did it make an extra api request to gain further details about the view? sounds interesting!! Sounds like a cleaner way than this big JSON list that's there now 😸 and no worries! glad to hear it's been working ok 👌 |
Right now Im just making the same api call as in the "workbooks" stream and then filter the records differently in order to arrive at a schema like this: schema = th.PropertiesList( The first two properties refer to workbook id and name. |
Hello G my favorite sheep,
I adjusted your tap a little bit for our use case. Having the "workbooks" stream returning the view data as a list, turned out a little bit inconvenient for us. I excluded it from the "workbooks" stream and created a separate stream for it. Are you interested in a PR implementing this change in your tap as well, or do you prefer your current version?
Cheers
Alex
The text was updated successfully, but these errors were encountered: