Sql fix #314
Sql fix #314
Conversation
| "MeasurementReportingInterval, ConnectionString, Enabled) VALUES({7}, {0}, {1}, {2}, {3}, {4}, {5}, {6})", | ||
| "acronym", "name", "protocolID", "framesPerSecond", "measurementReportingInterval", | ||
| "connectionString", "enabled"); |
There was a problem hiding this comment.
You need to also include a name for parameter 7. Probably, you should add 7 at the end and insert the name before acronym like so...
| "MeasurementReportingInterval, ConnectionString, Enabled) VALUES({7}, {0}, {1}, {2}, {3}, {4}, {5}, {6})", | |
| "acronym", "name", "protocolID", "framesPerSecond", "measurementReportingInterval", | |
| "connectionString", "enabled"); | |
| "MeasurementReportingInterval, ConnectionString, Enabled) VALUES({0}, {1}, {2}, {3}, {4}, {5}, {6}, {7})", | |
| "nodeID", "acronym", "name", "protocolID", "framesPerSecond", "measurementReportingInterval", | |
| "connectionString", "enabled"); |
| "acronym", "name", "protocolID", "framesPerSecond", "measurementReportingInterval", | ||
| "connectionString", "enabled"); | ||
|
|
||
| // Insert new device record | ||
| connection.ExecuteNonQuery(parameterizedQuery, acronym, name, protocolID, sourceWave.SampleRate, 1000000, $"wavFileName={FilePath.GetAbsolutePath(sourceFileName)}; connectOnDemand=true; outputSourceIDs={acronym}; memoryCache={useMemoryCache}", database.Bool(true)); | ||
| connection.ExecuteNonQuery(parameterizedQuery, acronym, name, protocolID, sourceWave.SampleRate, 1000000, $"wavFileName={FilePath.GetAbsolutePath(sourceFileName)}; connectOnDemand=true; outputSourceIDs={acronym}; memoryCache={useMemoryCache}", database.Bool(true), nodeID); |
There was a problem hiding this comment.
This old API for parameterized queries isn't as clever about matching arguments to your format string. Even if you use {7} as the first parameter in the query string, nodeID has to be the first argument to ExecuteNonQuery(). Also, you need database.Guid() or else it won't work for SQLite, PostgreSQL, or Oracle.
| connection.ExecuteNonQuery(parameterizedQuery, acronym, name, protocolID, sourceWave.SampleRate, 1000000, $"wavFileName={FilePath.GetAbsolutePath(sourceFileName)}; connectOnDemand=true; outputSourceIDs={acronym}; memoryCache={useMemoryCache}", database.Bool(true), nodeID); | |
| connection.ExecuteNonQuery(parameterizedQuery, database.Guid(nodeID), acronym, name, protocolID, sourceWave.SampleRate, 1000000, $"wavFileName={FilePath.GetAbsolutePath(sourceFileName)}; connectOnDemand=true; outputSourceIDs={acronym}; memoryCache={useMemoryCache}", database.Bool(true)); |
| command.Parameters.Add(measurement.ID); | ||
| command.Parameters.Add((long)measurement.Timestamp); | ||
| command.Parameters.Add(measurement.AdjustedValue); |
There was a problem hiding this comment.
I have a feeling this won't work. IDbCommand.Parameters returns a collection of type IDataParameterCollection which implements the non-generic IList interface. It's entirely possible that the MySQL implementation of the Add() method can convert any old value to an instance of IDbDataParameter, but I feel it's pretty unlikely. You'll need to use command.CreateParameter() and then set the ParameterName and Value fields for each parameter.
| @@ -330,7 +330,7 @@ public override void Augment(DataSet configuration) | |||
|
|
|||
| try | |||
| { | |||
| database.Connection.ExecuteNonQuery($"DELETE FROM TrackedChange WHERE ID <= {latestVersion}"); | |||
| database.Connection.ExecuteNonQuery("DELETE FROM TrackedChange WHERE ID <= {0}",latestVersion); | |||
There was a problem hiding this comment.
nit, whitespace
| database.Connection.ExecuteNonQuery("DELETE FROM TrackedChange WHERE ID <= {0}",latestVersion); | |
| database.Connection.ExecuteNonQuery("DELETE FROM TrackedChange WHERE ID <= {0}", latestVersion); |
| commandString.Append(')'); | ||
|
|
||
| command.CommandText = commandString.ToString(); | ||
| command.CommandText = "INSERT INTO Measurement VALUES ({0}, {1}, {2})"; |
There was a problem hiding this comment.
I missed this. Format strings only work with AdoDataConnection. Otherwise, you need to use the SQL syntax for parameters. In MySQL, that'd be @parameterName.
collins-self
force-pushed
the
SQL_Fix
branch
from
8f53593 to
781e00e
Compare
No description provided.