Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rocky Linux build automation #203

Open
jacksavage opened this issue Feb 22, 2024 · 1 comment
Open

Add support for Rocky Linux build automation #203

jacksavage opened this issue Feb 22, 2024 · 1 comment

Comments

@jacksavage
Copy link
Collaborator

The Rocky Linux jobs in /.gitlab-ci.yml have been virtually disabled using when: manual. This means they will only be run if someone clicks a button from the pipeline view in the GitLab UI. As the support for Rocky Linux build automation stands, an error is encountered when trying to install GridPACK to the container environment after running /usr/bin/python3 setup.py build. This can be seen in job #165811 on GitLab.

image

Originally posted by @jacksavage in #195 (comment)

@wperkins
Copy link
Member

wperkins commented Mar 6, 2024

At some point, CMake decided that case matters. This change solves this problem for me:

diff --git a/python/setup.py b/python/setup.py
index 0068efc8..90744ec9 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -40,6 +40,7 @@ class CMakeBuild(build_ext):
         extdir = os.path.abspath(os.path.dirname(self.get_ext_fullpath(ext.name)))
         cmake_args = ['-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=' + extdir,
                       '-DPYTHON_EXECUTABLE=' + sys.executable,
+                      '-DPython_EXECUTABLE=' + sys.executable,
                       '-DCMAKE_VERBOSE_MAKEFILE=YES' ]
 
         cfg = 'Debug' if self.debug else 'Release'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants