Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: New mapper to simplify adding values to matrix from user application #167

Open
abhyshr opened this issue Sep 22, 2023 · 2 comments
Assignees

Comments

@abhyshr
Copy link
Collaborator

abhyshr commented Sep 22, 2023

The current implementation of the generalized matrix mapper (and any matrix mapper ) makes inserting values in the matrix very difficult especially when there are large blocks on bus and branch. The user needs to calculate the number of values, calculate the row, col indices, and then the actual values etc., which, IMHO, is difficult. The matrix class in GridPACK has a nice way to insert the values in the matrix where one sets the row entry, column entry, and the value. Multiple values can also be set. Note that this format follows the PETSc matrix format and is very convenient in my opinion. So, I propose we pass the matrix directly to the application through matrixGetValues call. The user can call the method on the matrix to set values. This is very convenient in my opinion.

My plan is to create a new mapper by copying GenMatrixMap to do this. This will also need adding a new method to BaseComponent but that should be relatively straightforward. This will not break any existing code. The new mapper will be only used for the EMT application.

Any objections/better suggestions?

@bjpalmer @wperkins @chenyousu @yliu250

@abhyshr abhyshr self-assigned this Sep 22, 2023
@bjpalmer bjpalmer mentioned this issue Oct 9, 2023
49 tasks
@abhyshr
Copy link
Collaborator Author

abhyshr commented Oct 9, 2023

I think we should leave EMT application out of the release. It is a big change that I don't think we'll have ready by the release time. So this issue should be excluded from the release critical path.

@bjpalmer bjpalmer added this to the GridPACK 3.5 Release milestone Oct 11, 2023
@wperkins
Copy link
Member

Postpone to 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants