Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle system index set scoping #21174

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Handle system index set scoping #21174

wants to merge 9 commits into from

Conversation

patrickmann
Copy link
Contributor

@patrickmann patrickmann commented Dec 12, 2024

Resolves Graylog2/graylog-plugin-enterprise#5904

#21148 introduced scoping for index sets. We now need to make sure scope is accounted for.

Description

  • ensure that all system index sets have scope set to SystemIndexSetScope
  • use scope-aware methods for write operations on index sets

Motivation and Context

See linked issue

How Has This Been Tested?

  • first migration runs successfully
  • multiple migrations
  • system index sets cannot be deleted
  • regular index sets can be deleted

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@patrickmann patrickmann requested a review from thll December 12, 2024 16:03
@patrickmann patrickmann marked this pull request as ready for review December 12, 2024 16:04
@thll thll removed their request for review December 13, 2024 08:17
@patrickmann patrickmann requested a review from a team December 13, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant