Inject the backend query type map for pluggable backend selection #21121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always also bind backends in the generic map binder, even for versioned backends in non-versioned backends, use the map binder directly so the engine can pick the correct backend based on the BackendQuery instance used for query normalization, ignore non-elasticsearch based queries for now, we will need to address normalizers later to make them type safe (or just live with the instanceof check) Simplified version of #21073
kroepke
requested review from
dennisoelkers,
luk-kaminski and
janheise
and removed request for
dennisoelkers and
luk-kaminski
|
This is resolved now:
|
turns out mixing them doesn't work, because the elasticsearch-based ones have the same name, but all bindings are installed :(
luk-kaminski
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always also bind backends in the generic map binder, even for versioned backends
in non-versioned backends, use the map binder directly so the engine can pick the correct backend based on the BackendQuery instance used
for query normalization, ignore non-elasticsearch based queries for now, we will need to address normalizers later to make them type safe (or just live with the instanceof check)
Simplified version of #21073
The minimal version for making this work is in https://github.com/Graylog2/graylog-plugin-enterprise/pull/9343.
/nocl
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/9343
Types of changes