Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject the backend query type map for pluggable backend selection #21119

Closed
wants to merge 1 commit into from

Conversation

kroepke
Copy link
Member

@kroepke kroepke commented Dec 4, 2024

Description

always also bind backends in the generic map binder, even for versioned backends in non-versioned backends, use the map binder directly so the engine can pick the correct backend based on the BackendQuery instance used

for query normalization, ignore non-elasticsearch based queries for now, we will need to address normalizers later to make them type safe (or just live with the instanceof check)

/nocl

Simplified version of #21073

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

always also bind backends in the generic map binder, even for versioned backends
in non-versioned backends, use the map binder directly so the engine can pick the correct backend based on the BackendQuery instance used

for query normalization, ignore non-elasticsearch based queries for now, we will need to address normalizers later to make them type safe (or just live with the instanceof check)
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Kay Roepke seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kroepke kroepke marked this pull request as ready for review December 4, 2024 13:18
@kroepke kroepke closed this Dec 4, 2024
@kroepke kroepke deleted the queryengine-backend-selection branch December 4, 2024 13:19
@kroepke
Copy link
Member Author

kroepke commented Dec 4, 2024

screwed up the local user config on a new machine, I'll re-push this

@kroepke kroepke restored the queryengine-backend-selection branch December 4, 2024 13:21
@kroepke kroepke deleted the queryengine-backend-selection branch December 4, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants