Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISW - Wizard: Create New Stream #20569

Closed
grotlue opened this issue Sep 26, 2024 · 10 comments · Fixed by #21070
Closed

ISW - Wizard: Create New Stream #20569

grotlue opened this issue Sep 26, 2024 · 10 comments · Fixed by #21070
Labels

Comments

@grotlue
Copy link
Contributor

grotlue commented Sep 26, 2024

  • As part of the "Setup Routing" step
  • Shows a form to create a new stream with:
    • Title
    • Description (optional)
    • Index Set (select of existing index sets), refreshes regularly
      • only user-created ones (no illuminate or System Messages)
    • Checkbox: Remove matches from Default Stream
    • Checkbox: Create a new Pipeline for this Stream
    • Select of all existing pipelines (only one can be selected)
  • Shows a button "Create a New Index Set", on click
    • Opens the existing index set creation form in a new tab
  • Shows a button "All Done - Start Input" which leads to ISW - Wizard Step: Start Input Step #20567
  • The stream is not created at this point, but all the configuration will be set

f6332812-b728-4aba-b6bf-87d8e2b7b7f6#media-blob-url=true id=ad13e9a8-177b-4618-ab3e-3df4f306eea5 contextId=10149 collection=

@grotlue grotlue closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
@grotlue grotlue reopened this Sep 27, 2024
@grotlue
Copy link
Contributor Author

grotlue commented Sep 27, 2024

@tellistone If the user chooses to "Create a new Pipeline for this Stream" what exactly is the content of the pipeline? Is it just an "empty" one with a name?

@grotlue
Copy link
Contributor Author

grotlue commented Sep 30, 2024

@tellistone
Copy link

@tellistone If the user chooses to "Create a new Pipeline for this Stream" what exactly is the content of the pipeline? Is it just an "empty" one with a name?

Yes - empty pipeline with name that corresponds to the new stream, attached to the new stream

@grotlue
Copy link
Contributor Author

grotlue commented Oct 11, 2024

Added backend label as we need to routes the messages to the new stream

@grotlue
Copy link
Contributor Author

grotlue commented Oct 11, 2024

@tellistone Do I understand correctly that we want to ask the user if they want to create another custom stream?

@tellistone
Copy link

Yeah, their options are

  1. no routing, same as today
  2. pick an existing stream, we create routing to it
  3. create a new stream, optionally attach an existing pipeline to it, create routing to it

@grotlue grotlue removed the backend label Nov 6, 2024
@tellistone tellistone changed the title Wizard Step: Create New Stream ISW - Wizard Step: Create New Stream Nov 14, 2024
@tellistone
Copy link

In ui design, we should push the "Create a New Index Set" action as highly recommended.

@grotlue
Copy link
Contributor Author

grotlue commented Nov 27, 2024

For the contextual warning in the mockup there is no API. At least I couldn't find one that returns a list of streams connected to a specific index set. @patrickmann correct me if I'm wrong. I'd suggest to continue with this issue without that and if we want to have it, create a seperate one.

@patrickmann
Copy link
Contributor

The stream APIs do include information about index sets. To find all streams for a specific index set, you currently have to call GET /streams and then filter by the desired index set.

The BE already has a method indexSetIdsByIds to return all stream IDs for a given set of index IDs, but it is not exposed as an API.

@grotlue grotlue changed the title ISW - Wizard Step: Create New Stream ISW - Wizard: Create New Stream Nov 28, 2024
@grotlue
Copy link
Contributor Author

grotlue commented Dec 2, 2024

I think it would be a better solution if we can either can integrate the streams in the index sets list call or add a new call to get all streams for one index set (id).
I don't think it makes a lot of sense to get the whole stream list only for that use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants