Move secrets to secrets.json

GravitonINC · Aug 15, 2022 · 0e47c66 · 0e47c66
1 parent 14b13cb
commit 0e47c66
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -7,3 +7,5 @@ npm-debug.log*
 # JetBrains IntelliJ IDEA project files
 .idea
 *.iml
+
+secrets.json
diff --git a/bin/package.js b/bin/package.js
@@ -267,6 +267,7 @@ function buildDarwin (cb) {
     function signApp (cb) {
       const sign = require('electron-osx-sign')
       const { notarize } = require('electron-notarize')
+      const { appleId, appleIdPassword, teamId } = require('../secrets.json');
 
       /*
        * Sign the app with Apple Developer ID certificates. We sign the app for 2 reasons:
@@ -296,9 +297,9 @@ function buildDarwin (cb) {
       const notarizeOpts = {
         appBundleId: darwin.appBundleId,
         appPath,
-        appleId: '[email protected]',
-        appleIdPassword: '@keychain:AC_PASSWORD',
-        teamId: 'V75C78WU28',
+        appleId,
+        appleIdPassword,
+        teamId,
         tool: 'notarytool'
       }
 

diff --git a/secrets.json.example b/secrets.json.example
@@ -0,0 +1,5 @@
+{
+  "appleId": "[email protected]", // Email of the Apple ID used to sign the app
+  "appleIdPassword": "@keychain:AC_PASSWORD",  // App-specific password or keychain reference to a App-specific password for the Apple ID used to sign the app
+  "teamId": "ABC123" // Apple team id
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,3 +7,5 @@ npm-debug.log* @@
     # JetBrains IntelliJ IDEA project files
     .idea
     *.iml
+    secrets.json