Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape of a vector is ambiguous #41

Open
BenBrock opened this issue Nov 29, 2023 · 3 comments
Open

Shape of a vector is ambiguous #41

BenBrock opened this issue Nov 29, 2023 · 3 comments

Comments

@BenBrock
Copy link
Contributor

From reading the spec, it seems that it's ambiguous what we should put under the key shape when the format is DVEC. Do we want shape: 100? shape: [100]? Or shape: [100, 1]?

In order to work well with tensors, I'm guessing we want shape: [100], but we need to make sure it's unambiguous in the spec, and preferably add some examples.

@BenBrock
Copy link
Contributor Author

@willow-ahrens @eriknw and @ivirshup, do you have opinions here? If we have consensus, I'll go update the spec.

@eriknw
Copy link
Member

eriknw commented Nov 29, 2023

My opinion: clarify that vectors (including DVEC) are shape e.g. [100] (not 100).

@willow-ahrens
Copy link
Collaborator

Yes! This allows scalars to be shape []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants