-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.1.4 #255
v1.1.4 #255
Conversation
for array format, the first non-comment line must contain just two integers
bug fix for MMWrite (invalid output on array format)
…en the matrix is dense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
… puts it in system path but more correct if Tim has some reason for being specific.
experimental/test/test_BF.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to leave the debug prints in the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point -- I can take those out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some printfs were left in test_BF.c. Was that intentional?
…-build Michelp/v1.1 builtin graphblas build
Is this ready to go for a stable v1.1.4 release, or should we get the docs to pass first? |
I looked into this and the CI action that does the "Deploy" just posts the
coverage reports to the graphblas.org website, it doesn't deploy or
generate the docs.
For that, the docs need to be updates in the `rtdocs` folder. The "sphinx"
tool must be used to regenerate the docs and publish them. This will also
run the doxygen tool to generate the API documentation from the source.
I don't have sphinx and doxygen installed but I can take a stab at getting
this updated. At a minimum the copywrite and Authors list will need to be
updated in `rtdocs/conf.py`. Do we know who originally set this up? I
think Gabor was mentioned in the last call but might be good to get a
handoff from the last person to use it if there's any quirks around it.
…-Michel
On Fri, Aug 23, 2024 at 1:51 PM Tim Davis ***@***.***> wrote:
Is this ready to go for a stable v1.1.4 release, or should we get the docs
to pass first?
—
Reply to this email directly, view it on GitHub
<#255 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6BCOVVQBHFO35J7PMVYLZS6OG5AVCNFSM6AAAAABMNC5S3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXG44TIMRSGQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Looks like I was wrong about it not happening automatically, at least
according to the README in rtdocs there's a webhook that fires from
readthedocs that should build the docs now that you've pushed to stable,
although I'm not sure where that fires as there isn't an action in the CI.
I'll keep my eye on it today and if it doesn't build I'll investigate
further.
…On Fri, Aug 23, 2024 at 2:23 PM Tim Davis ***@***.***> wrote:
Merged #255 <#255> into stable.
—
Reply to this email directly, view it on GitHub
<#255 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6BCJPOCDM4PEP3PUFVC3ZS6R6NAVCNFSM6AAAAABMNC5S3CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHE4TQMBVGQYTSMQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This is the readthedocs project site:
https://readthedocs.org/projects/lagraph/
It may take some time to work but looks like last build was "6 months, 4
weeks ago". Does anyone have a login for this project to share?
On Fri, Aug 23, 2024 at 2:29 PM Michel Pelletier ***@***.***>
wrote:
… Looks like I was wrong about it not happening automatically, at least
according to the README in rtdocs there's a webhook that fires from
readthedocs that should build the docs now that you've pushed to stable,
although I'm not sure where that fires as there isn't an action in the CI.
I'll keep my eye on it today and if it doesn't build I'll investigate
further.
On Fri, Aug 23, 2024 at 2:23 PM Tim Davis ***@***.***>
wrote:
> Merged #255 <#255> into stable.
>
> —
> Reply to this email directly, view it on GitHub
> <#255 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA6BCJPOCDM4PEP3PUFVC3ZS6R6NAVCNFSM6AAAAABMNC5S3CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHE4TQMBVGQYTSMQ>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
Minor updates to build system (on Windows), and fix for LAGraph_MMWrite when the matrix is dense. Updates the github CI to use GraphBLAS 9.3.1.