-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing macOS 11 x86_64 wheels for 1.17.0 #276
Comments
I rely on
The |
Does seem you may be right about
|
I suspect that you now have to explicitly request an Intel runner, either macOS latest or using an earlier macOS version... Here's the sklearn cibuildwheel matrix for macos_x86_64: https://github.com/scikit-learn/scikit-learn/blob/fba028b07ed2b4e52dd3719dad0d990837bde28c/.github/workflows/wheels.yml#L111-L130 platform_id seems to be the critical bit. |
(as well as a fixed macOS version, rather than latest.) |
Am try 87fe726 at the moment. |
That is building:
Guess it looks like will be okay and I can release 1.17.1 to add it. |
Yes. GitHub changed macos-latest to arm runners, and cibuildwheel does not cross compile x86 from arm automatically. I strongly suggest bumping Also suggest adding pyproject.toml with cibulildwheel maintainer |
@GrahamDumpleton When we could expect release? |
Unfortunately I forgot to do it in rush just before went on trip, so can’t do it now until the end of the month as have no computer with me. |
I’ll see if I can get an old colleague I trust to do a release for me. It may take a few days to organize though. |
@GrahamDumpleton No hurry for me. I just Block 1.17.0 on our CI to keep it green. I was worried when activity in this issue was missed, but packing on a trip is a good place to miss release. |
Our macOS 13 intel builds are failing on 1.17. I'm not yet sure of the cause (wrapt seems to build correctly, or at least I can't see any visible build errors), but I noticed that 1.16 provides both x86_64 and arm64 wheels for macOS 11+, but 1.17 only provides arm64 wheels.
Looking at the release actions, I noticed "build wheels on macos-latest for auto" and "build wheels on macos-latest for arm64", but looking at the logs, both built arm64 wheels, so I'm wondering whether this was an unintentional change due to GHA changing the macos-latest to use ARM by default.
If this is an intentional drop then please feel free to close as wontfix — we can update our CI accordingly. But I couldn't find any information about dropping macOS Intel so I thought I would check here.
Thank you!
The text was updated successfully, but these errors were encountered: