Relocating packages is also changing properties

[sorin-florea]

Shadow Version

8.1.1

Gradle Version

8.8

Actual Behavior

I am trying to shadow oshi and relocate it, for example to com.relocated. The root package of oshi is oshi, which is also used in property names (e.g. oshi.util.proc.path)

https://github.com/ektaarora3501/oshi/blob/b9ccae3c9072996e6a07286c19503c9e5dc44199/oshi-core/src/main/java/oshi/util/platform/linux/ProcUtil.java#L45

String str = GlobalConfig.get("oshi.util.proc.path", "/proc");

will be rewritten to

String str = GlobalConfig.get("com.relocated.oshi.util.proc.path", "/proc");

Expected Behavior

The above code is wrong since the names of properties in property files will not be changed.

[vyazelenko]

I was just hit by the same issue.

[virustotalop]

You can try using a workaround like this https://github.com/Bastian/bstats-metrics/blob/master/base/src/main/java/org/bstats/MetricsBase.java#L241-L248 if you fork or otherwise control the code. Doesn't look like this will work for op's use-case but may work for others. I've had success using it in the past as seen here https://github.com/ClubObsidian/DynamicGui/blob/a9775fddbde9ef4620143fbb793003656d5a4ae8/bukkit/src/main/java/com/clubobsidian/dynamicgui/bukkit/entity/BukkitPlayerWrapper.java#L200-L204