Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited testing #1

Open
GordonLElliott opened this issue May 30, 2020 · 4 comments
Open

Limited testing #1

GordonLElliott opened this issue May 30, 2020 · 4 comments

Comments

@GordonLElliott
Copy link
Owner

I have only tested this (in its current version) on my own Windows 10 with Visual Studio 2019. (Prior versions were tested also on VS 2017, and I will do that again soon if my license is still active.)

While I don't consider this "ready for prime time" yet, I would appreciate anyone trying it out. A lot of cleanup of documentation is required, so in this thread I am asking for testing and not comments on documentation.

If you are successful, comment here. If not (perhaps here also but) please submit an issue.

@GordonLElliott
Copy link
Owner Author

I have now tested with both PostgreSQL version 10 in Win32 version, and PostgreSQL 12 in x64. The list of DLL files seems to be the same between versions, except the Win32 has slightly different names for the same DLLs in a couple of cases. So I suspect my DLL list built in the batch file is correct for all PostgreSQL versions, at least 10 and beyond.

@GordonLElliott
Copy link
Owner Author

I have used the current batch file to build using VS 2017 now. I explicitly enabled x64 compiling, didn't yet Win32. In my case I have both VS 2017 and VS 2019 installed, so I have to use the correct flags to utilize the 2017. You should see the variables needed to trigger the use of the proper flags up in the configuration section.

@GordonLElliott
Copy link
Owner Author

GordonLElliott commented Jun 16, 2020

The 0.0.6 version has "patching" feature to patch the CMake generated configuration files. Can be used to make efficiency improvements on Windows (quite dramatic). However the 7.1.2 master at time of this post has minor bugs so it won't compile with these efficiency patches. So either don't use, or manually update the source according to this message in which I updated and tested. When the fixes get caught up with 7.1.2 version master, then it passes all tests for both VS2017 and VS2019.

@GordonLElliott
Copy link
Owner Author

With libpqxx version 7.1.2 master (development), all necessary changes have been made as of morning of 2020, June 19, so that the library completely compiles with the efficiency patch version of this batch file. Testing on MSVC (Visual Studio) 2017 and 2019 with complete success of library compilation and test suite. By using the "patch" version or configuraiton of the batch file, floating point conversions are significantly improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant