Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update blank service with gke and cloudrun files #144

Merged
merged 2 commits into from
Nov 8, 2023
Merged

update blank service with gke and cloudrun files #144

merged 2 commits into from
Nov 8, 2023

Conversation

jonchenn
Copy link
Collaborator

@jonchenn jonchenn commented Nov 8, 2023 •
edited
Loading

  • Update blank_service to have the baseline for GKE or CloudRun as a microservice.
  • Bump to version 1.17.19.

@jonchenn jonchenn requested review from lukmanr and lavjain November 8, 2023 16:28
@jonchenn jonchenn mentioned this pull request Nov 8, 2023
Open
@lavjain
Copy link
Collaborator

lavjain commented Nov 8, 2023

We should also add Dockerfile and a blank README

@jonchenn
Copy link
Collaborator Author

jonchenn commented Nov 8, 2023

We should also add Dockerfile and a blank README

The Dockerfile already exists. Updated README.

@jonchenn jonchenn merged commit 416c389 into main Nov 8, 2023
3 checks passed
@lavjain lavjain deleted the update-blank-service branch November 19, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavjain lavjain lavjain approved these changes

@lukmanr lukmanr Awaiting requested review from lukmanr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonchenn @lavjain