This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
chore: release/v0.7.1 #847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ndbox into develop
Co-authored-by: Daniel Sanche <[email protected]>
* fix: update outdated loadgen env variable in sandboxctl * fix: authenticate loadgen before restarting loadgen
* fix develop telemetry * add a line to source environment variables Co-authored-by: Simon Zeltser <[email protected]>
* adding app_version as GKE cluster label +fmt * Add app_version var * feat(terraform): add GKE location to TF apply Use current GKE cluster location to avoid recreation + add gke_location var * fix(terraform):remove app version from this branch Co-authored-by: Ayelet41 <[email protected]> Co-authored-by: Daniel Sanche <[email protected]>
In this PR, we support both config-based and implementation-based SRE Recipe implementation. - The config-based SRE Recipe makes it fast to iterate and add new SRE Recipes, as discussed in the internal design review. It also helps reduce redundant, and hacky code. - The implementation-based SRE Recipe is kept for backward compatibility and allows for complex implementation needs that config-based SRE Recipe cannot do. - Documentations are added for both, with support for hiding/disabling recipes. - Migrated all existing SRE Recipe implementation to config-based YAML recipes - Added one dummy implementation-based recipe for future reference. - Updated sandboxctl to support running both types of recipes, using the samesandboxctl syntax right now. - Refactored generic, reusable shell commands to a standalone utils file, instead of putting them as static methods in (conceptually irrelevant) recipe classes.
* adding app_version as GKE cluster label +fmt * Update logic and description of app_version tf var
* fix(terraform): Update provider version constraints * fix(terraform):update providers in ratingservice and monitoring modules
…836) The validation mainly relies on the newest JSON Schema (https://json-schema.org) definition, and it works by first converting the YAML config to JSON, and then validate directly on the converted JSON. Added relevant README changes as well. In order to make decoupling JSON schema easier, I decided to write a custom schema bundling logic for schema "references", since the Python version of the JSON schema validator doesn't support referencing local files well.
github-actions
bot
requested review from
daniel-sanche and
simonz130
as code owners
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
google-cla
bot
added
the
cla: no
daniel-sanche
added
cla: yes
This was referenced Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.7.1
Features
Bug Fixes
Tests
Miscellaneous