This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add config-based SRE Recipe Implementation #826
feat: Add config-based SRE Recipe Implementation #826
Changes from 57 commits
ef597ae
70d2131
45029f4
ab110d9
07401f6
e4124c9
2df1748
e757f28
ca255b6
0b16538
635ad40
828453e
a48b7c9
f16af3f
4ff9864
0ad0639
7311472
bf710cf
ed9cb55
f92d826
601d4b0
3a8887a
fa4985e
0ec4e76
079081c
685625b
6622595
829d01b
d7ef1e3
8dd8aea
55abdd0
e3a2ddf
c7fac01
ab4099c
34c2db6
326498a
61a88cc
affda5c
9db7fe9
1accfad
a549aad
0b1158e
9e16e93
8435171
e2b6cf6
26a8303
db789c0
7c3bd2f
7a81330
1b5e978
c36ae89
4c9e5da
05058c2
e3d06d3
bd6807b
9318457
36902b6
5932ca8
943deb8
82a82ba
f81718a
c2bb35c
1a38a7e
ef47ab8
9a4ac8a
1783171
63911ed
bb28dee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we might want to be tolerant and allow yml extension too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given
.yaml
is recommended by YAML and we own this repo. Let's go with the consistent.yaml
extensionhttps://yaml.org/faq.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to define a grammar(structure) for the yaml config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot. But since the parsed YAML is in JSON format, we can use JSON-Schema library to do validation checks. I am planning to do that as a part of the follow-up PR for integration testing and validations.
https://stackoverflow.com/questions/3262569/validating-a-yaml-document-in-python