This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
feat: Support configuration-based provisioning of Cloud Ops artifacts (part 1) #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add schemas describing configuration for alerts, monitoring dashboards, log-based metrics, notification channels, SLOs and uptime checks. Schemas follow JSON schema standard (draft 2020-12).
minherz
force-pushed
the
minherz/implement-configuration
branch
8 times, most recently
from
ecb15ca to
485b88c
Compare
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
force-pushed
the
minherz/implement-configuration
branch
from
485b88c to
0058143
Compare
add empty placeholders for each type of artifacts as 'test' configuration
minherz
force-pushed
the
minherz/implement-configuration
branch
10 times, most recently
from
e5f2861 to
17e78e5
Compare
minherz
force-pushed
the
minherz/implement-configuration
branch
from
17e78e5 to
e1b4c67
Compare
minherz
force-pushed
the
minherz/implement-configuration
branch
5 times, most recently
from
938237f to
a8c6aa4
Compare
setup alerts configuration with realistic data. setup services configuration with realistic data. update alerts schema to support alert notification channel(s)
minherz
force-pushed
the
minherz/implement-configuration
branch
from
a8c6aa4 to
de2ad8a
Compare
Add configuration tests for metrics and healthchecks. Constraint app-id field in all schemas to prevent path injection.
minherz
changed the title
minherz
force-pushed
the
minherz/implement-configuration
branch
from
35dab4f to
81c06b6
Compare
Add test for dashboard configuration. Add test for SLO configuration including availability and latency SLOs.
minherz
force-pushed
the
minherz/implement-configuration
branch
from
81c06b6 to
8105f48
Compare
minherz
added a commit
that referenced
this pull request
Aug 7, 2023
… (part 1) (#1036) Add schemas describing configuration for alerts, monitoring dashboards, log-based metrics, notification channels, SLOs and uptime checks. Follow JSON schema standard (draft 2020-12). Add validation checks including linting and schema validation. Setup `/configurations/test` configuration to validate schema. This configuration will be further used to validate Terraform execution plan. Constraint app-id field in all schemas to prevent path injection.
minherz
added a commit
that referenced
this pull request
Sep 10, 2023
… (part 1) (#1036) Add schemas describing configuration for alerts, monitoring dashboards, log-based metrics, notification channels, SLOs and uptime checks. Follow JSON schema standard (draft 2020-12). Add validation checks including linting and schema validation. Setup `/configurations/test` configuration to validate schema. This configuration will be further used to validate Terraform execution plan. Constraint app-id field in all schemas to prevent path injection.
minherz
added a commit
that referenced
this pull request
Nov 25, 2023
… (part 1) (#1036) Add schemas describing configuration for alerts, monitoring dashboards, log-based metrics, notification channels, SLOs and uptime checks. Follow JSON schema standard (draft 2020-12). Add validation checks including linting and schema validation. Setup `/configurations/test` configuration to validate schema. This configuration will be further used to validate Terraform execution plan. Constraint app-id field in all schemas to prevent path injection.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Change the provisioning of the Cloud Ops Sandbox artifacts from being hardcoded in Terraform to the configured using external YAML files. Terraform will process the configuration's files to provision the same set of artifacts from the configuration. The specific configuration is determined based on the configuration's ID and the constant root path within the repository (i.e.
configurations/{ID}).This PR includes:
/configurationsfolder for configurations and/provisioning/schemas/configurationfor configuration's schemasWhich issue(s) this PR fixes:
Partially fixes #1020
Partially fixes #1026
Fixes #1037
Special notes for a reviewer:
See for feat: Support configuration-based provisioning of Cloud Ops artifacts (part 2) PR #1038