Skip to content
This repository has been archived by the owner on Nov 2, 2024. It is now read-only.

Commit

Permalink
feat: Add config-based SRE Recipe Implementation (#826)
Browse files Browse the repository at this point in the history
In this PR, we support both config-based and implementation-based SRE Recipe implementation.

- The config-based SRE Recipe makes it fast to iterate and add new SRE Recipes, as discussed in the internal design review. It also helps reduce redundant, and hacky code.
- The implementation-based SRE Recipe is kept for backward compatibility and allows for complex implementation needs that config-based SRE Recipe cannot do.
- Documentations are added for both, with support for hiding/disabling recipes.

- Migrated all existing SRE Recipe implementation to config-based YAML recipes
- Added one dummy implementation-based recipe for future reference.
- Updated sandboxctl to support running both types of recipes, using the samesandboxctl syntax right now.
- Refactored generic, reusable shell commands to a standalone utils file, instead of putting them as static methods in (conceptually irrelevant) recipe classes.
  • Loading branch information
Gan-Tu authored Sep 10, 2021
1 parent 8c22347 commit 13e46f7
Show file tree
Hide file tree
Showing 24 changed files with 1,078 additions and 887 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ terraform/istio/istioctl
terraform/istio/istio-*/**
.token
skaffold
website/resources*
website/resources*
srerecipes.log
163 changes: 0 additions & 163 deletions sre-recipes/recipe.py

This file was deleted.

Loading

0 comments on commit 13e46f7

Please sign in to comment.