Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous TestGetentPasswdOsloginUser failure in oslogin suite #80

Open
kajiya3141 opened this issue Aug 27, 2024 · 4 comments
Open

Ambiguous TestGetentPasswdOsloginUser failure in oslogin suite #80

kajiya3141 opened this issue Aug 27, 2024 · 4 comments
Assignees

Comments

@kajiya3141
Copy link
Contributor

N.B: We're currently pinned to commit c75566e63b2... but are planning to update the pin again very soon

Hey there everyone! 😄

The oslogin suite is looking much better now (down from 5 failures to just 1 - thanks again for the help there!), but we're still seeing a single failure in TestGetentPasswdOsloginUser:

 <?xml version="1.0" encoding="UTF-8"?>
 <testsuites time="35.420" tests="12" failures="1" skipped="4">
 	<testsuite name="oslogin-daily-ubuntu-2204-jammy-v20240823" tests="12" failures="1" errors="0" id="0" skipped="4" time="35.420">
 		<testcase name="TestOsLoginEnabled" classname="" time="0.000"></testcase>
 		<testcase name="TestGetentPasswdOsloginUser" classname="" time="0.080">
 			<failure message="Failed"></failure>
 		</testcase>
 		<testcase name="TestOsLoginDisabled" classname="" time="0.000"></testcase>
 		<testcase name="TestSSH" classname="" time="17.550"></testcase>
 		<testcase name="TestAdminSSH" classname="" time="1.850"></testcase>
 		<testcase name="Test2FASSH" classname="" time="3.970"></testcase>
 		<testcase name="Test2FAAdminSSH" classname="" time="3.400"></testcase>
 		<testcase name="TestAgent" classname="" time="8.570"></testcase>
 		<testcase name="TestGetentPasswdAllUsers" classname="oslogin-daily-ubuntu-2204-jammy-v20240823">
 			<skipped message=""><![CDATA[TestGetentPasswdAllUsers disabled on projects/ubuntu-os-cloud-devel/global/images/daily-ubuntu-2204-jammy-v20240823]]></skipped>
 		</testcase>
 		<testcase name="TestGetentPasswdOsloginUID" classname="oslogin-daily-ubuntu-2204-jammy-v20240823">
 			<skipped message=""><![CDATA[TestGetentPasswdOsloginUID disabled on projects/ubuntu-os-cloud-devel/global/images/daily-ubuntu-2204-jammy-v20240823]]></skipped>
 		</testcase>
 		<testcase name="TestGetentPasswdLocalUser" classname="oslogin-daily-ubuntu-2204-jammy-v20240823">
 			<skipped message=""><![CDATA[TestGetentPasswdLocalUser disabled on projects/ubuntu-os-cloud-devel/global/images/daily-ubuntu-2204-jammy-v20240823]]></skipped>
 		</testcase>
 		<testcase name="TestGetentPasswdInvalidUser" classname="oslogin-daily-ubuntu-2204-jammy-v20240823">
 			<skipped message=""><![CDATA[TestGetentPasswdInvalidUser disabled on projects/ubuntu-os-cloud-devel/global/images/daily-ubuntu-2204-jammy-v20240823]]></skipped>
 		</testcase>
 	</testsuite>
 </testsuites>

I'm struggling to replicate this locally, do you have any ideas? I'm wondering aloud if this is a permissions error to canonical-oslogin-cit, but I can't confirm that on my end.

Thanks in advance!
Chlo

@a-crate a-crate self-assigned this Sep 4, 2024
@a-crate
Copy link
Contributor

a-crate commented Sep 4, 2024

FYI @drewhli if you have any thoughts

@drewhli
Copy link
Contributor

drewhli commented Sep 4, 2024

If you have access to the serial logs for the instance that ran the test, that would be helpful. However, I think I know the root cause.

The test assumes that the default service account running on the instance has a POSIX account associated with it. If such a POSIX account doesn't exist, then the test segfaults, causing the ambiguous Failed error message. You'll probably see a panic message in the serial logs for the instance along the lines of panic: runtime error: index out of range [0] with length 0.

I'll put out a change to fix this so that the absence of an associated POSIX account does not cause this segfault and returns an error instead. In the meantime, you may need to connect to the VM using the default service account, and then check the login-profile to make sure a POSIX account exists.

@drewhli drewhli self-assigned this Sep 4, 2024
@a-crate
Copy link
Contributor

a-crate commented Sep 27, 2024

@kajiya3141 are you still seeing the same failure?

@kajiya3141
Copy link
Contributor Author

Sorry all, I missed this notification! Let me follow up and get back to you when we've re-enabled CIT across our test matrix again soon 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants