Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add support for identity columns in import/export #1812

Merged

Conversation

hengfengli
Copy link
Contributor

No description provided.

@hengfengli hengfengli requested a review from a team as a code owner August 26, 2024 06:22
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.

Project coverage is 45.98%. Comparing base (d96bd95) to head (a03ec33).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...oud/teleport/spanner/AvroSchemaToDdlConverter.java 77.77% 0 Missing and 4 partials ⚠️
.../com/google/cloud/teleport/spanner/ddl/Column.java 71.42% 0 Missing and 4 partials ⚠️
...om/google/cloud/teleport/spanner/ddl/Sequence.java 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1812      +/-   ##
============================================
+ Coverage     45.95%   45.98%   +0.02%     
- Complexity     3799     3810      +11     
============================================
  Files           851      851              
  Lines         50805    50844      +39     
  Branches       5343     5359      +16     
============================================
+ Hits          23349    23381      +32     
+ Misses        25762    25760       -2     
- Partials       1694     1703       +9     
Components Coverage Δ
spanner-templates 67.60% <74.46%> (+0.01%) ⬆️
spanner-import-export 65.56% <74.46%> (+0.06%) ⬆️
spanner-live-forward-migration 76.30% <ø> (ø)
spanner-live-reverse-replication 77.25% <ø> (ø)
spanner-bulk-migration 86.87% <ø> (ø)
Files with missing lines Coverage Δ
...va/com/google/cloud/teleport/spanner/AvroUtil.java 93.75% <ø> (ø)
...oud/teleport/spanner/DdlToAvroSchemaConverter.java 93.03% <100.00%> (+0.19%) ⬆️
.../teleport/spanner/ddl/DatabaseOptionAllowlist.java 100.00% <100.00%> (ø)
...oud/teleport/spanner/AvroSchemaToDdlConverter.java 83.56% <77.77%> (-0.33%) ⬇️
.../com/google/cloud/teleport/spanner/ddl/Column.java 83.17% <71.42%> (-1.77%) ⬇️
...om/google/cloud/teleport/spanner/ddl/Sequence.java 66.66% <20.00%> (-1.91%) ⬇️

... and 2 files with indirect coverage changes

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Sep 2, 2024
@hengfengli hengfengli force-pushed the support-identity-column branch 2 times, most recently from 7861bc6 to 16caba6 Compare October 30, 2024 03:02
VardhanThigle
VardhanThigle previously approved these changes Nov 5, 2024
@VardhanThigle VardhanThigle added addition New feature or request improvement labels Nov 5, 2024
@VardhanThigle VardhanThigle merged commit 6a50180 into GoogleCloudPlatform:main Dec 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants