-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acsploit #60
Comments
Their password to check against us is now no problem, it's taken care of by the max length configuration implemented here: c387d54 The code that generated this password: https://github.com/twosixlabs/acsploit/blob/fd5602adf9f312482b8010abf6b4691f08929bc4/acsploit/exploits/passwords/zxcvbn.py It still takes ~400ms to calculate, but that can can be worked on separately. This got rid of the pathological case by default.
|
As @formigarafa mentioned here: #74 (comment) I went an implemented a check for dictionary max length to short cut a lot of logic. In the dev branch, this is now running in ~70ms with the password limited to 256 characters total:
|
There was another exploit mentioned in the main zxcvbn repo: dropbox/zxcvbn#327 This has to do with the lazyAnchored check we do in the repeat matcher, but it isn't being hit for us now as mentioned in that thread. |
I found a blog post explaining the exploit from the authors: https://twosixtech.com/algorithmic-complexity-vulnerabilities-an-introduction/ |
I noticed that nbvcxz was mentioned as being targeted by: https://github.com/twosixlabs/acsploit
Ensure the generated passwords don't cause issues.
The text was updated successfully, but these errors were encountered: